synapse icon indicating copy to clipboard operation
synapse copied to clipboard

Use `max_upload_size` as the limit when following the `Location` header

Open S7evinK opened this issue 1 year ago • 2 comments

Otherwise we use the expected_size from the initial federation request, which might be far too low.

Pull Request Checklist

  • [x] Pull request is based on the develop branch
  • [x] Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • [x] Code style is correct (run the linters)

S7evinK avatar Aug 08 '24 13:08 S7evinK

Complement failing seems unrelated.

S7evinK avatar Aug 08 '24 13:08 S7evinK

Though a regression test would be good

erikjohnston avatar Aug 14 '24 13:08 erikjohnston