synapse icon indicating copy to clipboard operation
synapse copied to clipboard

Support MSC3757: Restricting who can overwrite a state event

Open AndrewFerr opened this issue 1 year ago • 3 comments

Link to the MSC

Pull Request Checklist

  • [x] Pull request is based on the develop branch
  • [x] Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • [x] Code style is correct (run the linters)

AndrewFerr avatar Aug 01 '24 03:08 AndrewFerr

The new & edited unit tests cover the MSC's auth rules. Since they all pass, this PR is ready for review.

AndrewFerr avatar Aug 08 '24 15:08 AndrewFerr

Can you expand the title of this PR? Each time I see a notification for it I wonder what MSC3757 is.

clokep avatar Aug 12 '24 19:08 clokep

I think the feature will need to be opt-in via configuration rather than enabled by default.

This is already opt-in by virtue of working only in rooms of a compatible version (org.matrix.msc3757.9 / .10 / .11).

AndrewFerr avatar Aug 13 '24 12:08 AndrewFerr

Also note that this has Complement tests: https://github.com/matrix-org/complement/pull/733

AndrewFerr avatar Sep 11 '24 14:09 AndrewFerr

(Complement CI is expected to fail until https://github.com/matrix-org/complement/pull/733 is merged.)

AndrewFerr avatar Sep 18 '24 12:09 AndrewFerr

Changed the base branch to release-v1.116 so that I can do another RC with it included

sandhose avatar Sep 26 '24 13:09 sandhose