element-hq
Allow Docker image to be built on Windows
Sometimes (often) Git forgets to CRLF->LF and this breaks execution of /start.py because #!/usr/local/bin/python\r can't be found (noting carriage return).
maybe we should add a .gitattributes of * text eol=lf instead?
Changing the dockerfile kind of feels like the wrong level for this, and what limit does it stop at? :S
I'm not sure the gitattributes would be enough to make Git for Windows happy, but can certainly give it a try on my next Synapse PR :)
I'm not sure the gitattributes would be enough to make Git for Windows happy, but can certainly give it a try on my next Synapse PR :)
By this, do you mean that you're going to add a .gitattributes file in your next PR, or that you're hoping we add one?
Taking this out of the review queue for now while the alternative is evaluated.
I'm not sure the gitattributes would be enough to make Git for Windows happy, but can certainly give it a try on my next Synapse PR :)
By this, do you mean that you're going to add a
.gitattributesfile in your next PR, or that you're hoping we add one?
sorry, missed this: I was hoping to give it a try the next time I touch Synapse. This PR can sit until then, or be closed - whichever the team prefers.