Local media retention doesn't delete from DB

[erikjohnston]

For media_retention.local_media_lifetime we call:

https://github.com/element-hq/synapse/blob/696cc9e802f63ba8657856d85f6982f49de14f27/synapse/media/media_repository.py#L1254

which is wrong

[dklimpel]

Local media IDs will deleted:

https://github.com/element-hq/synapse/blob/696cc9e802f63ba8657856d85f6982f49de14f27/synapse/media/media_repository.py#L1257

https://github.com/element-hq/synapse/blob/696cc9e802f63ba8657856d85f6982f49de14f27/synapse/storage/databases/main/media_repository.py#L907-L912

But it's really not ideal.

[erikjohnston]

Oooh, good spot!