element-x-ios icon indicating copy to clipboard operation
element-x-ios copied to clipboard
verified publisher icon element-hq

Profiles often don’t load in timeline.

Open ara4n opened this issue 1 year ago • 2 comments

Steps to reproduce

  1. open a room for the first time in a session
  2. about 30% of the time, no profiles load - just raw mxids:

IMG_7912

  1. go back to roomlist and reenter room
  2. profiles now appear

Outcome

What did you expect?

reliable profiles everywhere

What happened instead?

racey flakiness

Your phone model

No response

Operating system version

No response

Application version

667

Homeserver

No response

Will you send logs?

No

ara4n avatar Aug 01 '24 21:08 ara4n

(this is with SSS)

ara4n avatar Aug 02 '24 13:08 ara4n

...although i think it was also happening pre-SSS

ara4n avatar Aug 02 '24 15:08 ara4n

This indeed has nothing to do with SSS. I can easily reproduce it by dropping the connection after loading timeline items/backpaginating.

It does also fix itself when the timeline item in question re-appears on screen.

Both of these are expected per https://github.com/element-hq/element-x-ios/blob/develop/ElementX/Sources/Services/Timeline/TimelineController/RoomTimelineController.swift#L400 and https://github.com/element-hq/element-x-ios/blob/develop/ElementX/Sources/Services/Timeline/TimelineController/RoomTimelineController.swift#L143

What would the new desired behavior be, should I additionally re-fetch all of them when the network conditions change?

stefanceriu avatar Aug 12 '24 07:08 stefanceriu