element-x-ios icon indicating copy to clipboard operation
element-x-ios copied to clipboard

Pinned items timeline implementation for the banner

Open Velin92 opened this issue 1 year ago • 2 comments

fixes #3072

Requires https://github.com/matrix-org/matrix-rust-sdk/pull/3773 to be merged

Velin92 avatar Jul 29 '24 15:07 Velin92

Warnings
:warning: Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
:warning: You seem to have made changes to views. Please consider adding screenshots.

Generated by :no_entry_sign: Danger Swift against 431a90cb48f5b89b3a29e089f609f2434a22a1bb

github-actions[bot] avatar Jul 29 '24 15:07 github-actions[bot]

Codecov Report

Attention: Patch coverage is 46.15385% with 77 lines in your changes missing coverage. Please review.

Project coverage is 77.72%. Comparing base (cdaa88e) to head (10702ce).

Files Patch % Lines
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 22.85% 27 Missing :warning:
...om/RoomSummary/RoomMessageEventStringBuilder.swift 0.00% 27 Missing :warning:
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 66.66% 10 Missing :warning:
...ices/Room/RoomSummary/RoomEventStringBuilder.swift 66.66% 4 Missing :warning:
...tX/Sources/Other/Extensions/AttributedString.swift 0.00% 3 Missing :warning:
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 50.00% 2 Missing :warning:
...ne/TimelineController/RoomTimelineController.swift 0.00% 2 Missing :warning:
...lineController/RoomTimelineControllerFactory.swift 0.00% 1 Missing :warning:
NSE/Sources/NotificationContentBuilder.swift 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3099      +/-   ##
===========================================
- Coverage    77.80%   77.72%   -0.09%     
===========================================
  Files          713      713              
  Lines        54994    55078      +84     
===========================================
+ Hits         42786    42807      +21     
- Misses       12208    12271      +63     
Flag Coverage Δ
unittests 68.22% <46.15%> (-0.08%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 05 '24 09:08 codecov[bot]