element-x-ios icon indicating copy to clipboard operation
element-x-ios copied to clipboard

[WIP] QR Code Login Flow

Open Velin92 opened this issue 1 year ago • 4 comments

requires an sdk branch which contains the qr code login APIs to compile

fixes #2622

Velin92 avatar Apr 29 '24 12:04 Velin92

Warnings
:warning: This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
:warning: Please add a changelog.
:warning: Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
:warning: You seem to have made changes to views. Please consider adding screenshots.

Generated by :no_entry_sign: Danger Swift against 683a5342e964227d7ecc1d6e1031a1ec2f2768ee

github-actions[bot] avatar Apr 29 '24 12:04 github-actions[bot]

:iphone: Scan the QR code below to install the build for this PR. :lock: This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Ceqb8g

github-actions[bot] avatar May 02 '24 13:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 62.18236% with 253 lines in your changes are missing coverage. Please review.

Project coverage is 78.08%. Comparing base (66a8f6f) to head (683a534).

Files Patch % Lines
...X/Sources/Services/QRCode/QRCodeLoginService.swift 0.00% 77 Missing :warning:
...tensions/AVMetadataMachineReadableCodeObject.swift 45.94% 60 Missing :warning:
...QRCodeLoginScreen/QRCodeLoginScreenViewModel.swift 69.23% 28 Missing :warning:
ElementX/Sources/Application/AppMediator.swift 0.00% 17 Missing :warning:
...ens/QRCodeLoginScreen/View/QRCodeScannerView.swift 65.00% 14 Missing :warning:
...owCoordinators/AuthenticationFlowCoordinator.swift 0.00% 12 Missing :warning:
...ens/QRCodeLoginScreen/View/QRCodeLoginScreen.swift 92.00% 10 Missing :warning:
ElementX/Sources/Application/AppSettings.swift 0.00% 8 Missing :warning:
ElementX/Sources/Application/AppCoordinator.swift 0.00% 7 Missing :warning:
...adataMachineReadableCodeObjectExtensionsTest.swift 76.92% 6 Missing :warning:
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2767      +/-   ##
===========================================
- Coverage    78.19%   78.08%   -0.11%     
===========================================
  Files          680      685       +5     
  Lines        52631    53254     +623     
===========================================
+ Hits         41155    41586     +431     
- Misses       11476    11668     +192     
Flag Coverage Δ
unittests 68.55% <62.18%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 02 '24 15:05 codecov[bot]