element-x-ios icon indicating copy to clipboard operation
element-x-ios copied to clipboard

Edits sometimes show original msg, not edited msg.

Open ara4n opened this issue 2 years ago • 8 comments

Steps to reproduce

  1. Send a message on another client (EW in this case)
  2. Someone reacts to it (this may or may not be important)
  3. Edit your msg
  4. More reactions happen

Later, view the msg in scrollback on EX. It’s shown as edited, but the contents shows the pre-edited contents, not the edited content! 🙀

concretely:

image

is a msg i sent, and then fixed the thinko of “go” to “typescript”. but the edit doesn’t show up.

Outcome

What did you expect?

reliable edits

What happened instead?

flakey timeline code.

Your phone model

No response

Operating system version

No response

Application version

463

Homeserver

No response

Will you send logs?

Yes

ara4n avatar Dec 15 '23 17:12 ara4n

rageshake is down so i can't submit logs. https://matrix.to/#/!IIDRCwzJTNnOmMxacp%3Amatrix.org/%24BkoaVoIn-FFKS64JNoVQUiJuF7e_IG0J1wB-Z41A7BQ is the msg in q

ara4n avatar Dec 15 '23 17:12 ara4n

it often seems to flip back and forth - i just saw it flap between the edited and non edited version in the timeline about 3 times after having sent the edit...

ara4n avatar Dec 27 '23 11:12 ara4n

see also https://github.com/element-hq/element-x-ios/issues/1895

ara4n avatar Jan 20 '24 13:01 ara4n

Still 100% reproducible (reactions don't matter). They fix themselves after re-entering the room after having loaded them once and then break again when clearing out the cache.

stefanceriu avatar Jun 21 '24 06:06 stefanceriu

Already reported on the RustSDK under https://github.com/matrix-org/matrix-rust-sdk/issues/3492

stefanceriu avatar Jun 21 '24 06:06 stefanceriu

@Hywan could this be fixed by the event cache storage?

manuroe avatar Jun 21 '24 06:06 manuroe

@Hywan could this be fixed by the event cache storage?

it is not.

manuroe avatar Jul 11 '24 09:07 manuroe

still getting it on build 690

ara4n avatar Aug 27 '24 17:08 ara4n

I've closed the SDK issue, because lots of engineering work has been spent on this, and most issues should now be fixed. As explained there, please open new issues if that happens again, with precise STRs; the symptom (missing edit) can be caused by many causes; for instance, there are some rageshakes here that relate to local echoes for edits, unrelated to the original issue filed here. Thanks!

bnjbvr avatar Oct 10 '24 13:10 bnjbvr

thanks @bnjbvr for all the fixes. Let's close this issue and create more accurate ones if needed.

manuroe avatar Oct 10 '24 13:10 manuroe