element-x-ios icon indicating copy to clipboard operation
element-x-ios copied to clipboard

Toolbar icons disappear after hiding app on iPad

Open marwing opened this issue 2 years ago • 3 comments

Steps to reproduce

  1. Open app on iPad
  2. Go back to home screen
  3. Wait a few seconds
  4. Open app
  5. Notice the toolbar being empty and the view being scrolled up for the title to be in the toolbar

https://github.com/vector-im/element-x-ios/assets/29716248/d7cb2a21-d7c0-4c29-8a94-87549c4d8bf9

Outcome

What did you expect?

IMG_0122 or at least IMG_0124

In my opinion, hiding the app should never update the scroll position, so the first image is the actually expected one.

What happened instead?

IMG_0125

This can be fixed by restarting the app or resizing it small enough to show the room list and the room timeline on different screens (like on the iPhone), e.g., by entering split screen or in stage manager.

Your phone model

iPad Pro

Operating system version

iPadOS 17.0.3

Application version

1.3.3 (76)

Homeserver

Synapse 1.94.0

Will you send logs?

No

marwing avatar Oct 18 '23 09:10 marwing

As noted by #2604 this also affects the detail's toolbar when a room is selected.

pixlwave avatar Mar 25 '24 10:03 pixlwave

Just updated to 1.7.3 and this is still an issue.

Makes it really hard to report bugs on iPadOS when I can't get to the menus.

kenrachynski avatar Aug 14 '24 02:08 kenrachynski

Well the good news it that Apple introduced new APIs that would allow us to rewrite a bunch of the code around this. The bad news is that we need to wait until we switch over to iOS 18

stefanceriu avatar Aug 14 '24 06:08 stefanceriu

there is not a simple fix for this without rewriting and loosing support for ios 16?

ledlamp avatar Oct 03 '24 06:10 ledlamp

there is not a simple fix for this without rewriting and loosing support for ios 16?

To directly answer the question, the new iOS 18 APIs we'd like to use back-deploy to iOS 16, so this change wouldn't directly result in 16 being cut off (although it's possible to use different APIs on different OS versions so it wouldn't necessarily be cut off if the back-deployment wasn't there).

Unrelated to this change, we only intend to guarantee support for the 2 most recent major iOS versions in Element X. There will always be a bit of a "migration" period where we support 3 while we figure out the right point at which we cut off support for the older one.

pixlwave avatar Oct 03 '24 08:10 pixlwave