element-x-ios icon indicating copy to clipboard operation
element-x-ios copied to clipboard
verified publisher icon element-hq

Autocorrect on macOS breaks input

Open domoritz opened this issue 2 years ago • 16 comments

Steps to reproduce

I use element X on macOS (Mac with apple silicon) on Sonoma. Try typing a longer message.

Outcome

I noticed that whenever I encounter a place where the OS auto-completes a word, the beginning of the word gets removed. This is pretty common and definitely easy to reproduce with any sentence. However, I found that if I type the same word again, the message doesn't break.

Your phone model

macBook pro

Operating system version

macOS Sonoma

Application version

1.3.0 (72)

Homeserver

No response

Will you send logs?

No

domoritz avatar Sep 22 '23 18:09 domoritz

I don't think this is occasional. For me this happens in almost every single message so that Element X is pretty much useless on Mac. I use Element X on my phone exclusively but on Mac I always use Element because of this bug.

domoritz avatar Nov 19 '23 22:11 domoritz

In this instance, occasional refers to the fact that the overwhelming majority of our users are on iPhone rather than Mac.

pixlwave avatar Nov 20 '23 08:11 pixlwave

Somehow the iOS version breaks Chinese (probably CJK) input.

Slide to type can reliably reproduce this feature.

Kimiblock avatar Nov 20 '23 09:11 Kimiblock

I think this issue is also happening on iOS where if I do a backspace when a recommendations shown, element X keeps the recommendation after the cursor.

domoritz avatar Feb 21 '24 02:02 domoritz

Duplicate of https://github.com/element-hq/element-x-ios/issues/2491

manuroe avatar Mar 01 '24 09:03 manuroe

It's probably the same underlying bug and since the other issue is marked as higher severity/frequency it makes sense to dupe.

domoritz avatar Mar 02 '24 06:03 domoritz

Reopening this as per https://github.com/element-hq/element-x-ios/issues/2491#issuecomment-2143197811

stefanceriu avatar Jun 03 '24 08:06 stefanceriu

fixed on the latest version

Velin92 avatar Jul 16 '24 13:07 Velin92

In 1.6.13?

domoritz avatar Jul 16 '24 19:07 domoritz

it's on develop, so it will be available in the next release

Velin92 avatar Jul 17 '24 11:07 Velin92

I have 1.7.1 (117) and autocomplete is still broken on macOS. Can you confirm the version this is fixed in?

domoritz avatar Jul 30 '24 16:07 domoritz

yes it should contain the fix for iOS, maybe the issue is still persisting on mac, do you mind showing it to us on 1.7.1?

Velin92 avatar Aug 05 '24 10:08 Velin92

Thanks for looking into this. This is on the latest versions:

https://github.com/user-attachments/assets/db04f344-cdec-4731-966b-06ddfc84861b

domoritz avatar Aug 05 '24 11:08 domoritz

@Velin92 can you reopen the issue?

domoritz avatar Aug 13 '24 21:08 domoritz

Okay I see, the issue is not in the RTE, but on the plain composer. In the meantime the issue should be fixed if you enable the formatting toolbar which will use the rich text editor composer, we will investigate what is wrong with the plain text one.

Velin92 avatar Aug 14 '24 09:08 Velin92

It happens for me in both composers. Using macOS 14.6.1 and Element X Version 1.7.3 (119).

https://github.com/user-attachments/assets/02b28b2a-db1b-493d-8e70-258a0200bdd6

Edit: I'm not sure if that is relevant, but I have multiple Input Sources enabled: German, 2-Set Korean, and U.S.

josephnoir avatar Aug 26 '24 09:08 josephnoir