element-x-android icon indicating copy to clipboard operation
element-x-android copied to clipboard

The incoming call UI appears much less frequently.

Open YamatoRyou opened this issue 2 months ago • 19 comments

Steps to reproduce

When calling from another device, wait for the incoming call UI to appear.

Outcome

What did you expect?

I wish this UI would appear for every incoming call.

What happened instead?

After updating to 25.10.1, I've noticed that this UI rarely appears. I've made a video demonstrating this: https://www.youtube.com/watch?v=iG54Pdpmn1g

The video shows three phones involved in the test, and the call process was repeated 11 times. This video is unedited. As you can see from the video, the UI didn't appear 11 times on each device as expected (or at a satisfactory frequency). One device didn't even appear once from the beginning to the end. This issue also occurred in previous versions, but not to the same degree as it is now.

Battery, background restrictions, notifications, permissions, and other factors that affect notification appearance have been eliminated, and all devices use the same self-hosted ntfy instance as the push gateway.

Logs: {BC758E23-B829-B71D-A702-783789107412}.zip Password: *** Please download this file as soon as possible.

Your phone model

See Video.

Operating system version

See Video.

Application version and app store

Element X Android 25.10.1

Homeserver

Synapse 1.140.0

Will you send logs?

Yes

Are you willing to provide a PR?

No

YamatoRyou avatar Oct 23 '25 08:10 YamatoRyou

I see lots of:

2025-10-23T07:58:54.067305Z DEBUG elementx: [DefaultActiveCallManager] Received timed-out incoming ringing call for room id: ..., cancel ringing | 

As if the received notification's expiration value was already past, so the call UI is not displayed.

And also a few of these:

2025-10-23T07:33:09.460542Z TRACE matrix_sdk_ui::notification_client: all notification events havenot  been found | crates/matrix-sdk-ui/src/notification_client.rs:596 | spans: try_sliding_sync

But I don't really know what causes them, there's not much info in the logs about it.

If you go back to the previous version, can you confirm this works well again? Maybe my changes in https://github.com/element-hq/element-x-android/pull/5563 somehow caused this regression.

Also, I'm on 25.10.1 and I can't reproduce it in my test device with a similar setup.

jmartinesp avatar Oct 23 '25 09:10 jmartinesp

I also noticed this issue soon after upgrading to 25.10.1. It doesn't even trigger the vibration - my phone is always on vibration mode - (neither on my phone nor on my smartwatch).

In addition it appears the element-call ringing period is too small. On the receiving end the phone doesn't ring long enough to answer the call because the sender side finishing the call too soon.

escix avatar Oct 23 '25 09:10 escix

I see lots of:

2025-10-23T07:58:54.067305Z DEBUG elementx: [DefaultActiveCallManager] Received timed-out incoming ringing call for room id: ..., cancel ringing | 

As if the received notification's expiration value was already past, so the call UI is not displayed.

And also a few of these:

2025-10-23T07:33:09.460542Z TRACE matrix_sdk_ui::notification_client: all notification events havenot  been found | crates/matrix-sdk-ui/src/notification_client.rs:596 | spans: try_sliding_sync

But I don't really know what causes them, there's not much info in the logs about it.

If you go back to the previous version, can you confirm this works well again? Maybe my changes in #5563 somehow caused this regression.

Also, I'm on 25.10.1 and I can't reproduce it in my test device with a similar setup.

I downgraded device B to EXA (25.10.0) and re-recorded the test video. This time, 23 calls were repeated, with the remaining test conditions remaining the same. https://www.youtube.com/watch?v=FEqs8rEz2Bs

As you can see, after the downgrade, device B failed to display the incoming call UI only once, while the performance of the other devices remained consistent with the previous test (perhaps slightly better, but still not satisfactory).

YamatoRyou avatar Oct 23 '25 12:10 YamatoRyou

Ok, then I think we can try reverting my changes and checking if that makes a difference. If it does, I'll try improving it in a separate PR later, if it doesn't then we should keep looking for other possible culprits.

jmartinesp avatar Oct 23 '25 13:10 jmartinesp

I experience this issue as well on my phone since the latest pre-release. (202510010) Sometimes it rings, sometimes it is just a notification "You have new messages.", I only experience it with calls. I did a rage shake with mentioning this issue. If I turn on the Sync notification wirh WorkManager, it doesn't make any difference. Also sometimes, more rare I don't get noisy notifications from messages. This is only exist on my Samsung Galaxy A52s phone, on my Pixel 9 it works properly.

sndrtms avatar Oct 25 '25 10:10 sndrtms

I am also getting this on the same version 25.10. 1 it's like while I'm getting a call, UI not showing and like 1 ring and goes silent then I have to open the app to join the call... Also to be noted sometimes app notification only appears when opening app

PH03N1X999 avatar Oct 26 '25 19:10 PH03N1X999

@YamatoRyou , @sndrtms , @PH03N1X999 can I ask you to please install the debug APK generated in https://github.com/element-hq/element-x-android/pull/5615 and test if those changes fix your issues?

jmartinesp avatar Oct 27 '25 12:10 jmartinesp

@YamatoRyou , @sndrtms , @PH03N1X999 can I ask you to please install the debug APK generated in #5615 and test if those changes fix your issues?

It has been tested just now and has returned to normal. App: ee67d3eb

YamatoRyou avatar Oct 27 '25 14:10 YamatoRyou

@YamatoRyou , @sndrtms , @PH03N1X999 can I ask you to please install the debug APK generated in #5615 and test if those changes fix your issues?

It has been tested just now and has returned to normal. App: ee67d3eb

So it was caused by that PR. I'm reverting it now, thanks for testing it!

jmartinesp avatar Oct 27 '25 14:10 jmartinesp

Sorry for the late reply, I tested it as well. That debug APK worked properly for me on every devices I have.

sndrtms avatar Nov 01 '25 14:11 sndrtms

@jmartinesp, @bmarty Unfortunately, this made to the playstore and EC is no longer ringing. Can we swiftly make an interim release or downgrade to the previous version in the playstore?

rajil avatar Nov 03 '25 04:11 rajil

@jmartinesp, @bmarty Unfortunately, this made to the playstore and EC is no longer ringing. Can we swiftly make an interim release or downgrade to the previous version in the playstore?

Sorry for the delay, we've made a hotfix release (still in review in google play) https://github.com/element-hq/element-x-android/releases/tag/v25.11.0. It should be available soon, if the review process goes well.

jmartinesp avatar Nov 03 '25 15:11 jmartinesp

@jmartinesp, @bmarty Unfortunately, this made to the playstore and EC is no longer ringing. Can we swiftly make an interim release or downgrade to the previous version in the playstore?

Sorry for the delay, we've made a hotfix release (still in review in google play) https://github.com/element-hq/element-x-android/releases/tag/v25.11.0. It should be available soon, if the review process goes well.

I had already tried this version early via Github, but I found the problem persists. I then compared it with the nightly release (25.10.1-98acdadc) released today, which works fine.

YamatoRyou avatar Nov 03 '25 15:11 YamatoRyou

@YamatoRyou So v25.11.0 does not fix this problem?

rajil avatar Nov 03 '25 19:11 rajil

@YamatoRyou So v25.11.0 does not fix this problem?

Yes, but this conclusion is based on "I didn't log in again". You can try logging in again (clearing app data before logging in) and then testing again; it might help.

YamatoRyou avatar Nov 03 '25 20:11 YamatoRyou

I had already tried this version early via Github, but I found the problem persists. I then compared it with the nightly release (25.10.1-98acdadc) released today, which works fine.

I'm not really sure what's going on then, because the hotfix version is the previous version which had the issue + the PR you and others confirmed fixed the issue...

jmartinesp avatar Nov 03 '25 21:11 jmartinesp

I had already tried this version early via Github, but I found the problem persists. I then compared it with the nightly release (25.10.1-98acdadc) released today, which works fine.

I'm not really sure what's going on then, because the hotfix version is the previous version which had the issue + the PR you and others confirmed fixed the issue...

I'll try logging in again when I have some free time.

YamatoRyou avatar Nov 03 '25 21:11 YamatoRyou

@jmartinesp Just confirming notifications work on Samsung Galaxy S10 5G and S23 Ultra for v25.11.0

FTR, the notifications were working on previous two releases too in Galaxy S10 5G, it just played up on my S23 Ultra BUT after deleting the NTFY link and recreate it, the notifications worked without any issues.

Hope this helps.

So the PR may not be required.

Further: I think the issue is with the timeout of the element-call rather than notifications setting. With the element-call sending it's own notification but the timeout is too short (30s ?) in some cases the caller timeout before the element-call can appear in the receiver's app.

escix avatar Nov 05 '25 04:11 escix

Reinstall with v25.10.1 (google play store edition) did not fix the issue with S22. Waiting for v25.11.0 to come out on playstore.

rajil avatar Nov 05 '25 13:11 rajil