element-x-android icon indicating copy to clipboard operation
element-x-android copied to clipboard

Change animation on cold start by a fader animation.

Open bmarty opened this issue 2 months ago • 5 comments

Also cleanup all our transition handler.

Content

Improve cold start by removing the sliding animation

Motivation and context

Improve UI

Screenshots / GIFs

Tests

  • Kill the app
  • Start the app
  • Observe that the room list / login screen is displayed with a fader animation instead of a slider animation.

Tested devices

  • [ ] Physical
  • [x] Emulator
  • OS version(s):

Checklist

  • [ ] Changes have been tested on an Android device or Android emulator with API 24
  • [ ] UI change has been tested on both light and dark themes
  • [ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • [ ] Pull request is based on the develop branch
  • [ ] Pull request title will be used in the release note, it clearly define what will change for the user
  • [ ] Pull request includes screenshots or videos if containing UI changes
  • [ ] You've made a self review of your PR

bmarty avatar Oct 02 '25 13:10 bmarty

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/y7DJei

github-actions[bot] avatar Oct 02 '25 14:10 github-actions[bot]

Draft as it breaks animation where we may want to keep a slider like when the user signs out.

bmarty avatar Oct 02 '25 14:10 bmarty

Codecov Report

:x: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 81.07%. Comparing base (73627d9) to head (c108ee4).

Files with missing lines Patch % Lines
...braries/architecture/animation/ScreenTransition.kt 0.00% 3 Missing :warning:
...ent/android/libraries/architecture/BaseFlowNode.kt 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5447      +/-   ##
===========================================
- Coverage    81.07%   81.07%   -0.01%     
===========================================
  Files         2317     2317              
  Lines        63628    63630       +2     
  Branches      8032     8032              
===========================================
  Hits         51588    51588              
- Misses        9104     9106       +2     
  Partials      2936     2936              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 02 '25 14:10 codecov[bot]

I tried this out and immediately noticed that the room list doesn't slide left when opening and closing rooms. It's not bad; just a bit different. Is that an intentional side-effect?

frebib avatar Oct 03 '25 14:10 frebib