element-x-android icon indicating copy to clipboard operation
element-x-android copied to clipboard

Rework room summary

Open ganfra opened this issue 4 months ago • 2 comments

Content

This PR takes care of 3 things :

  • Do not use RoomSummary directly in the ui model, so creates new models when necessary
  • Let RoomSummary uses RoomInfo directly instead of mapping partial data.
  • Rework the getRoomInfoFlow to not use getRoom internally.

Motivation and context

Better code and prepare work for knocking feature.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • [ ] Physical
  • [ ] Emulator
  • OS version(s):

Checklist

  • [ ] Changes have been tested on an Android device or Android emulator with API 23
  • [ ] UI change has been tested on both light and dark themes
  • [ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • [ ] Pull request is based on the develop branch
  • [ ] Pull request title will be used in the release note, it clearly define what will change for the user
  • [ ] Pull request includes screenshots or videos if containing UI changes
  • [ ] Pull request includes a sign off
  • [ ] You've made a self review of your PR

ganfra avatar Oct 08 '24 19:10 ganfra