element-x-android icon indicating copy to clipboard operation
element-x-android copied to clipboard

Element X allows D2D backups

Open lucasmz-dev opened this issue 1 year ago • 3 comments

Steps to reproduce

  1. Backup using Seedvault on D2D mode
  2. Element X atores a significant amount of data
  3. Backup without D2D mode
  4. Element X does not backup anything

Outcome

What did you expect?

The older regular does not use the Android backup API at all, and blocks any attempts, hence I would've expected the same for X.

What happened instead?

Backups are allowed in D2D mode.

Your phone model

Moto G52

Operating system version

Android 14

Application version and app store

Element X 6.0

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No

lucasmz-dev avatar Sep 16 '24 01:09 lucasmz-dev

This might not be necessarily a defect, Element could decide D2D are safe and perhaps use them. One thing I haven't tested is restoring these, would it work or would some encryption key get lost?

Mostly I'm pointing this out due to it being different from regular Element. The only real way it affects me is that it backs up 300MB of which I really don't need, but that's somewhat expected out of D2D mode on Seedvault which pretends to be a D2D transfer.

lucasmz-dev avatar Sep 16 '24 01:09 lucasmz-dev

Backup is disabled on Element Android and on Element X (see https://github.com/element-hq/element-x-android/blob/main/app/src/main/AndroidManifest.xml#L16). Is there something I am missing here?

bmarty avatar Sep 16 '24 14:09 bmarty

That works for regular cloud backups, but it doesn't cover D2D (device to device) transfers

Regular Element managed to exclude that

lucasmz-dev avatar Sep 16 '24 14:09 lucasmz-dev

Update: I restored one of these backups in Seedvault, and it just resulted in nothing. I had to log in again. It doesn't work seem to work, so it's just basically wasting storage. For regular D2D transfers, this means basically that Element X transfers extra data that won't be used; for Seedvault, same thing but with storage.

Seedvault is now D2D only FWIW

Note: D2D = device to device, device to device transfers, etc

lucasmz-dev avatar Dec 31 '24 17:12 lucasmz-dev