element-x-android icon indicating copy to clipboard operation
element-x-android copied to clipboard

Filter pills display inconsistent

Open kongo09 opened this issue 1 year ago • 4 comments

Steps to reproduce

  1. Observe room list
  2. Filter for people
  3. Observe filter pills
  4. Unselect the people filter and select the rooms filter
  5. Observe filter pills

Outcome

What did you expect?

When I filter for people, the pill for rooms disappears, which I expect, as there cannot be any room left to filter for once people is selected. The room filter this doesn't make sense and is removed.

However, I still see the filter for unreads even though I don't have any unread DMs. I would expect that filter to disappear as well.

Now, when the filter for rooms is selected, the people pill rightfully disappears. But the pill for invites disappears as well, even though I have a room invite. I would have expected that invite filter to remain.

What happened instead?

Unread filter remains shown when people filter is selected and leads to an empty state if selected.

Invites filter is not shown when room filter is selected even though there is a room invite.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No

kongo09 avatar Jul 13 '24 13:07 kongo09

All your remarks were products decisions and are excepted to be like that.

ganfra avatar Jul 19 '24 12:07 ganfra

@mxandreas please take a look at this product decision, ideally together with @amshakal . Maybe I miss something here, but from a user perspective, it doesn't feel right.

kongo09 avatar Jul 20 '24 09:07 kongo09

My take is that this is something that may be quite personal - e.g. may "not feel right" for one person but be fine for another. I would leave it as is until we get some more evidence how this is confusing for several users or impractical in certain situations.

I see two concise options: a) Hiding the pills by excluding the situations that can never happen (e.g. something can not be a room and a person at the same time) - this seems to be the current logic. b) Hiding the pills based on the current actual situation (e.g. hiding unread if you actually do not have any unread messages).

On top of that one could argue if "room" and "invite" to room are overlapping entities or not. It seems that current logic is that they are not, and I do not see anything immediately wrong with it.

mxandreas avatar Jul 22 '24 06:07 mxandreas

Happy to wait for more insights.

kongo09 avatar Jul 22 '24 08:07 kongo09

FTR this is the meta story https://github.com/element-hq/element-meta/issues/2283

Closing the issue since no changes are needed right now on EXA.

bmarty avatar Aug 19 '24 10:08 bmarty