element-x-android icon indicating copy to clipboard operation
element-x-android copied to clipboard

Creating several rooms results in a room preview being displayed

Open jmartinesp opened this issue 1 year ago • 4 comments

Steps to reproduce

  1. From the room list, create a new room, you should be taken into it immediately.
  2. Go back to the room list.
  3. Now create another room.
  4. Instead of opening the new room, you'll see the room preview of the just created room instead.
  5. If you go back to the room list, you won't be able to find the room in the list either until the app is restarted.

Outcome

What did you expect?

The create room flow to be consistent.

What happened instead?

After the first room is created, the flow is broken.

Your phone model

Xiaomi Mi 9

Operating system version

Android 14

Application version and app store

Element X Nightly (0.4.17)

Homeserver

No response

Will you send logs?

Yes

Are you willing to provide a PR?

Yes

jmartinesp avatar Jul 12 '24 09:07 jmartinesp

Status when testing on 2024-07-23 nightly:

  • New rooms appear at the top of list as expected 🥳
  • The room preview screen can still be displayed after the room creation 😢 . I got this bug 33% of the time.

manuroe avatar Jul 23 '24 13:07 manuroe

@ganfra was not able to reproduce it on 0.4.16. The regression happened between 0.4.16 and 0.5.0.

manuroe avatar Jul 24 '24 08:07 manuroe

Ok so after some digging, the steps are :

  • we create the room
  • we wait for the room to appear in the RoomList
  • we try to get a room from the associated RoomListItem => we got an exception from rust sdk RoomListException$InitializingTimeline: error=Room !DKIcUGPMMbrsaYEPYC:matrix.org` not found``
  • It never recovers from that as we are expecting to have a full room at this point

ganfra avatar Jul 24 '24 12:07 ganfra

I can't reproduce the issue anymore. @ganfra do you know a good way to make it easy to reproduce?

jmartinesp avatar Aug 06 '24 10:08 jmartinesp

I tested it on the today nightly. The room preview screen appears every time I create a room on matrix.org, even for the first created room. I linked a rageshake to this issue in case it helps.

manuroe avatar Sep 06 '24 14:09 manuroe

Project management trick: I moved this issue from the SSS project tasklist to the release blockers tasklist. Now, it is less related to SSS but more a global issue.

manuroe avatar Sep 11 '24 08:09 manuroe

This should be fixed by https://github.com/matrix-org/matrix-rust-sdk/pull/3979 once we build a new SDK version and add the new API call to wait until the room is synced.

jmartinesp avatar Sep 12 '24 11:09 jmartinesp

Let's close the issue and open it again if it does not work as expected.

bmarty avatar Sep 16 '24 14:09 bmarty