Sign in with QR code

[jmartinesp]

Type of change

• [ ] Feature
• [ ] Bugfix
• [ ] Technical
• [ ] Other :

Content

Motivation and context

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• [ ] Physical
• [ ] Emulator
• OS version(s):

Checklist

• [ ] Changes have been tested on an Android device or Android emulator with API 23
• [ ] UI change has been tested on both light and dark themes
• [ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• [ ] Pull request is based on the develop branch
• [ ] Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• [ ] Pull request includes screenshots or videos if containing UI changes
• [ ] Pull request includes a sign off
• [ ] You've made a self review of your PR

[ElementBot]

	Warnings
:warning:	gradle/libs.versions.toml#L12 - A newer version of androidx.core:core-ktx than 1.13.0 is available: 1.13.1
:warning:	gradle/libs.versions.toml#L18 - A newer version of androidx.datastore:datastore-preferences than 1.0.0 is available: 1.1.1
:warning:	gradle/libs.versions.toml#L21 - A newer version of androidx.lifecycle:lifecycle-runtime-ktx than 2.7.0 is available: 2.8.1
:warning:	gradle/libs.versions.toml#L22 - A newer version of androidx.activity:activity-compose than 1.8.2 is available: 1.9.0
:warning:	gradle/libs.versions.toml#L24 - A newer version of androidx.camera:camera-view than 1.3.2 is available: 1.3.3
:warning:	gradle/libs.versions.toml#L69 - A newer version of com.google.gms:google-services than 4.4.1 is available: 4.4.2
:warning:	gradle/libs.versions.toml#L71 - A newer version of com.google.firebase:firebase-bom than 33.0.0 is available: 33.1.0
:warning:	gradle/libs.versions.toml#L213 - A newer version of androidx.appcompat:appcompat than 1.6.1 is available: 1.7.0

Generated by :no_entry_sign: dangerJS against 7fad1a64f5399a7b9a4c101881b283a8b7f39ce0

[github-actions[bot]]

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/E1WZPB

[jmartinesp]

Thanks for the early review! I don't know why I didn't see any notifications related to this earlier 🤔 .

We should probably have a timeout as well?

I'd expect that to come from the Rust SDK to be honest, if the EW side cancelled the login because of the timeout we should receive something on the EX side. And similarly, if we want to cancel the process with a timeout on EX instead maybe it should be provided to the Rust SDK and the SDK should handle this.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 78.96440% with 130 lines in your changes are missing coverage. Please review.

Project coverage is 75.52%. Comparing base (d89004f) to head (7fad1a6). Report is 16 commits behind head on develop.

Files	Patch %	Lines
...ement/android/libraries/qrcode/QrCodeCameraView.kt	69.86%	15 Missing and 7 partials :warning:
...s/login/impl/screens/qrcode/scan/QrCodeScanView.kt	83.69%	2 Missing and 13 partials :warning:
...login/impl/screens/qrcode/error/QrCodeErrorView.kt	80.30%	0 Missing and 13 partials :warning:
...eens/qrcode/confirmation/QrCodeConfirmationView.kt	84.84%	0 Missing and 10 partials :warning:
...d/libraries/designsystem/utils/ForceOrientation.kt	0.00%	10 Missing :warning:
...login/impl/screens/qrcode/intro/QrCodeIntroView.kt	73.52%	0 Missing and 9 partials :warning:
...element/android/libraries/qrcode/QRCodeAnalyzer.kt	50.00%	7 Missing :warning:
...in/impl/screens/qrcode/scan/QrCodeScanPresenter.kt	84.21%	1 Missing and 5 partials :warning:
...ignsystem/utils/ForceOrientationInMobileDevices.kt	0.00%	5 Missing :warning:
...ment/android/features/login/api/LoginEntryPoint.kt	0.00%	4 Missing :warning:
... and 16 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2793      +/-   ##
===========================================
+ Coverage    75.43%   75.52%   +0.08%     
===========================================
  Files         1547     1576      +29     
  Lines        36845    37413     +568     
  Branches      7139     7262     +123     
===========================================
+ Hits         27793    28255     +462     
- Misses        5318     5358      +40     
- Partials      3734     3800      +66     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[jmartinesp]

Can we retest this @bmarty, @ganfra and merge it if it's fine?

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[hughns]

I've tested the latest build against synapse-oidc.lab.element.dev with no issues found.