Move attachment preview above the composer, allowing to add captions …

[surakin]

…to media/attachments

Fixes #2573

I has too many UX changes for my taste so if one of the team likes it and wants to pick it up that's fine by me :)

Type of change

• [x] Feature
• [ ] Bugfix
• [ ] Technical
• [ ] Other :

Content

Motivation and context

Screenshots / GIFs

Before sending After sending

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• [x] Physical
• [x] Emulator
• OS version(s):

Checklist

• [x] Changes have been tested on an Android device or Android emulator with API 23
• [ ] UI change has been tested on both light and dark themes
• [ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• [x] Pull request is based on the develop branch
• [ ] Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• [x] Pull request includes screenshots or videos if containing UI changes
• [x] Pull request includes a sign off
• [ ] You've made a self review of your PR

[github-actions[bot]]

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

• Your branch should be based on origin/develop, at least when it was created.
• There is a changelog entry in the changelog.d folder with the Towncrier format.
• The test pass locally running ./gradlew test.
• The code quality check suite pass locally running ./gradlew runQualityChecks.
• If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

[frebib]

Is it necessary to keep the Sending {spinner} box with this change?

[surakin]

Is it necessary to keep the Sending {spinner} box with this change?

I understand this is the only feedback until https://github.com/matrix-org/matrix-rust-sdk/issues/1732 is sorted out

[frebib]

A small bug I noticed today: Trying to send a captioned image as a reply sends okay, but doesn't attach the reply metadata to the event and leaves the reply box in the composer

[surakin]

A small bug I noticed today: Trying to send a captioned image as a reply sends okay, but doesn't attach the reply metadata to the event and leaves the reply box in the composer

Hmmm sending replies with anything other than text is not supported yet anyway Maybe disabliing attachments on reply mode would be enough for now

[cyrneko]

Hmmm sending replies with anything other than text is not supported yet anyway

In what sense? I have seen many users (especially beeper users) send images in reply to messages and they get rendered in EXA just fine, is there a limitation on the Rust-SDK's end maybe? :thinking:

[surakin]

Hmmm sending replies with anything other than text is not supported yet anyway

In what sense? I have seen many users (especially beeper users) send images in reply to messages and they get rendered in EXA just fine, is there a limitation on the Rust-SDK's end maybe? 🤔

Yes, afaik the rust SDK can only reply with text so far.

[frebib]

I just realised that you can't edit captions with this after I typo'd one today

[CLAassistant]

All committers have signed the CLA.

[bmarty]

Thanks for the proposal. We will work very soon on this part, and it will be possible to add a caption (and do other actions on the media), in the preview screen.