element-web icon indicating copy to clipboard operation
element-web copied to clipboard
verified publisher icon element-hq

MVVM WidgetContextMenu component to shared component

Open MarcWadai opened this issue 2 months ago • 2 comments

Parent issue https://github.com/element-hq/element-web/issues/29633 This PR will be needed for WidgetCard to be moved as a shared-component. In PR

Changes

  • Port WidgetContextMenu to be a sharedcomponent
  • Use compound-web Menu and context instead of EW

MarcWadai avatar Nov 06 '25 17:11 MarcWadai

CI seems unhappy

Now only the shared component visual test failed with 0.3081597222222222% difference in the snapshots... Do i need to install something specific on my local to match what the CI is doing ?

MarcWadai avatar Dec 12 '25 09:12 MarcWadai

I haven't touched the shared-components stack yet so not sure, best asking in one of the dev rooms.

t3chguy avatar Dec 12 '25 09:12 t3chguy

I guess you didn't have any luck figuring out why the snapshots didn't match? We may have to have the CI upload the snapshot images so we can see what's going wrong.

dbkr avatar Dec 18 '25 10:12 dbkr

@dbkr I succeed running the screenshot update locallly thx to Florian PR on the subject. Still got an error on the storybook though :sweat_smile: ARIA hidden element must not be focusable or contain focusable elements (aria-hidden-focus) . I am going on holiday now, but I will try to take a look asap

MarcWadai avatar Dec 18 '25 12:12 MarcWadai