element-web icon indicating copy to clipboard operation
element-web copied to clipboard

Update the mobile_guide page to the new design and link out to Element X by default.

Open pixlwave opened this issue 7 months ago • 5 comments

This PR reverts #30104 (restoring #30006) and makes the following additional changes:

  • Fix yarn build on Windows.
    • Webpack was failing to pack the gradient image defined in the CSS file.
    • Handling the mobile_guide assets in getAssetOutputPath resolved this.
  • Set the default mobile app variant to Element X as requested by product.
    • Anyone who wishes to continue linking to Element Classic will need to set mobile_guide_app_variant to "classic" as detailed in the configuration docs.

Linking to #30056 for visibility.

pixlwave avatar Jun 19 '25 18:06 pixlwave

And now the screenshot tests fail on Linux. But not my local Linux where they pass. I now appreciate how nice it is to only have to target one OS 🙈

pixlwave avatar Jun 19 '25 18:06 pixlwave

@pixlwave looks like its loading the images wrong

image

double /mobile_guide/

t3chguy avatar Jun 20 '25 07:06 t3chguy

Yeah, I've reverted the use of those requires. That wasn't part of the fix on Windows (just seemed nice to do), so 🤞 this should all be happy now.

pixlwave avatar Jun 20 '25 09:06 pixlwave

Nice, looks like it passed this time.

pixlwave avatar Jun 20 '25 09:06 pixlwave

Hmm, all the screenshots seem to say Element Pro - that doesn't seem right

My bad, completely missed that last time round.

pixlwave avatar Jun 20 '25 10:06 pixlwave

@t3chguy Is there anything more you need from me to get this one merged?

pixlwave avatar Jun 26 '25 08:06 pixlwave