element-web icon indicating copy to clipboard operation
element-web copied to clipboard
verified publisher icon element-hq

Visually broken 'remove alias' button

Open dbkr opened this issue 1 year ago • 5 comments

Steps to reproduce

  1. Find a room where you have admin
  2. Open settings
  3. Add a local alias if it doesn't already have one
  4. See: Screenshot 2024-09-02 at 10 11 19

Outcome

What did you expect?

Something that looks like a delete button

What happened instead?

An 'x' and a separate tiny red blob

Operating system

No response

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

dbkr avatar Sep 02 '24 09:09 dbkr

Hi @dbkr, I would like to work on this issue but new to matrix.org. Can you please elaborate on how do I find room with an admin (mentioned in step 1).

jenish064 avatar Sep 06 '24 05:09 jenish064

If you create a room, you'll have admin in it.

dbkr avatar Sep 06 '24 08:09 dbkr

241019_05h25m47s_screenshot

I fixed it. What should I do now? Should I send the pull request?

Dev-Gurjar avatar Oct 19 '24 00:10 Dev-Gurjar

the size of the button has to be big otherwise the button for closing room settings will get broken.

trying to attach the changes - d0faf72a09b2d2295466bf93887d2b4edf80ba25

Dev-Gurjar avatar Oct 19 '24 05:10 Dev-Gurjar

@Dev-Gurjar Yes, you should open a pull request. More information in the contributing guide.

florianduros avatar Oct 21 '24 08:10 florianduros

Fixed in https://github.com/element-hq/element-web/issues/27985

florianduros avatar Oct 28 '24 14:10 florianduros