element-web icon indicating copy to clipboard operation
element-web copied to clipboard

Button to close side panel is missing

Open kongo09 opened this issue 1 year ago • 10 comments

Steps to reproduce

  1. Click on (i) in header to open side panel on the right

Outcome

What did you expect?

A button to close the side panel, typically an X in the top right

What happened instead?

No obvious way to close the side panel is visible

image

Side panel in Edge:

image

Side panel in Slack:

image

Side panel toggle button in MS Teams

image

It seems a X is typical, but even without the X there are alternatives in the top right to close the panel

Operating system

Windows 11

Application version

Element version: 1.11.71 Crypto version: Rust SDK 0.7.1 (80a151e), Vodozemac 0.6.0

How did you install the app?

element.io

Homeserver

element.io

Will you send logs?

No

kongo09 avatar Jul 22 '24 18:07 kongo09

I noticed another weird thing. If I hit the Threads icon because, hey, it has a notification bubble, the right panel closes and does not show Threads, instead of switching over to the Threads section:

image

kongo09 avatar Jul 23 '24 17:07 kongo09

That is as design asked for it

t3chguy avatar Jul 24 '24 07:07 t3chguy

we need to figure out the close button. I also 'miss' it and get confused by how it's there sometimes and now there other times. I've connected this to the Epic to work on after first launch and will discuss it with @americanrefugee when back

daniellekirkwood avatar Jul 24 '24 08:07 daniellekirkwood

To me what @kongo09 mentioned in his comment seems like a very obvious bug and was immediatley confusing to people I talked to. @t3chguy Should this be treated as a separate issue?

tibroc avatar Jul 31 '24 12:07 tibroc

You can file a separate issue, it won't change how Design/Product investigate/think about it, but might be cleaner.

t3chguy avatar Jul 31 '24 12:07 t3chguy

Our suggested solution is to drop the tabs and introduce a close button [x] to the far right of the right panel - we're just gathering feedback on the designs before committing to this solution... What would y'all think to that?

What that might look like 👇 Screenshot 2024-08-13 at 12 26 20

Screenshot 2024-08-13 at 12 26 33

@tibroc as for the buttons opening the right place in the right panel instead of closing the right panel, we'll address that too. We don't need an issue to track it (unless you already made one?)

daniellekirkwood avatar Aug 13 '24 11:08 daniellekirkwood

Why not keep the tabs and just add an X button? That seems like the most straightforward solution involving minimum effort.

opusforlife2 avatar Aug 13 '24 11:08 opusforlife2

@daniellekirkwood The screenshots you provide seem like a good idea to me. It also removes the duplicated functionality between the buttons and the tabs, so it is already less confusing.

I did not yet open a separte issue, so I'm fine with tracking progress here.

tibroc avatar Aug 13 '24 12:08 tibroc

We drew up what keeping the tabs and introducing the [x] would look like and it gets really 'busy' as you'd also need a scroll bar to see all the tabs.

Screenshot 2024-08-13 at 13 44 37

To tibroc's point, removing the tabs removes the duplicated functionality

daniellekirkwood avatar Aug 13 '24 12:08 daniellekirkwood

Oh, right. I didn't notice that the pre-existing buttons still remain along with the tabs. Then yeah, removing the tabs makes sense. They don't serve any purpose.

opusforlife2 avatar Aug 13 '24 13:08 opusforlife2

Screenshot 2024-09-18 082355 do we still need to add [X] icon to close the right Side panel ?

Krishcode264 avatar Sep 18 '24 02:09 Krishcode264

Yes, we will be reintroducing the close button. Thanks for catching that I had not yet updated the content of this issue!

daniellekirkwood avatar Sep 18 '24 07:09 daniellekirkwood

Screenshot 2024-09-18 at 08 57 33

daniellekirkwood avatar Sep 18 '24 07:09 daniellekirkwood