element-web
element-web copied to clipboard
element-hq
Binary settings choice with inconsistent interaction pattern
Steps to reproduce
- Go to settings
- Observe a binary setting choice
Outcome
What did you expect?
Always the same pattern, i.e. either a toggle or a checkbox
What happened instead?
Sometimes toggles, sometimes checkboxes
Operating system
Windows 11
Application version
Element version: 1.11.61 Crypto version: Olm 3.2.15
How did you install the app?
No response
Homeserver
element.io
Will you send logs?
No
This is another issue that would most likely be addressed by the redesign of settings described in https://github.com/element-hq/element-web/issues/27180#issuecomment-2004370784
Agree with @robintown I've added this item to the list WRT the Settings update project.
@kongo09 I suggest that we close this issue as it will be handled with the Settings redesign.
If you disagree, feel free to reopen this task.
Settings redesign currently still has two patterns for the same binary choice, e.g. in notifications.
Indeed this should be redesigned as part of the settings work we're doing. There might be a reasoning to explain why we use different components. @americanrefugee I'll leave you to review this if needed.
There are only a few places we're using checkboxes:
- Notifications > Email summary: Multi-select list of emails
- Sidebar > Spaces to show > Home: "Show all rooms" is a modifier of the binary option
- Security & Privacy > Privacy settings > How to find you: Multi-select list of emails
Otherwise all binary options are indeed a toggle. The only actual exception being the checkbox for "Show all rooms", which was so that primary option and the modifier felt more connected.
