element-web icon indicating copy to clipboard operation
element-web copied to clipboard

New compound button colors feel very bright and aggressive in the dark theme.

Open MTRNord opened this issue 4 months ago • 1 comments

Steps to reproduce

  1. Open the settings for example

Outcome

What did you expect?

A theme that is not disturbing to look at for long times

What happened instead?

image

The buttons have very harsh contrasts, making it hard for me to read and look at them for extended amounts of time (aka anything more than 30s).

Operating system

Fedora Silverblue 39

Browser information

Firefox 121.0.1 (64-bit)

URL for webapp

develop.element.io

Application version

Version von Element: 92c831094d11-react-ed5ef023b24b-js-d03db1740586 Krypto-Version: Rust SDK 0.7.0 (fac36bc), Vodozemac 0.5.1

Homeserver

matrix.midnightthoughts.space

Will you send logs?

No

MTRNord avatar Feb 13 '24 23:02 MTRNord

Because these parts of the interface weren't designed with the new Compound colors in mind, we're definitely overapplying those bright, punchy primary buttons here. This situation will get better as we redesign more of the application to use Compound buttons in a way that matches their visual weight, but I think changing some of these buttons to secondary ahead of a redesign is also reasonable.

robintown avatar Feb 14 '24 00:02 robintown

On the second iteration of this change (https://github.com/matrix-org/matrix-react-sdk/pull/12299) I changed some of these buttons to secondary where appropriate.

robintown avatar Mar 05 '24 16:03 robintown