element-web icon indicating copy to clipboard operation
element-web copied to clipboard

[Disabled] Flaky playwright test: `Spotlight > should find unknown people`

Open richvdh opened this issue 2 years ago • 9 comments

Timed out retrying after 10000ms: Expected to find element: .mx_SpotlightDialog_section.mx_SpotlightDialog_results .mx_SpotlightDialog_option, but never found it.

https://github.com/matrix-org/matrix-react-sdk/actions/runs/6115896270/job/16600238039#step:8:20244

richvdh avatar Sep 08 '23 00:09 richvdh

https://cloud.cypress.io/projects/ppvnzg/runs/19256/test-results/dd4050c3-96e7-48fa-8ae2-b7fe7377f23b

richvdh avatar Sep 20 '23 20:09 richvdh

My current hypothesis is that the rooms are created too quickly before the profile information is populated in Synapse. https://github.com/matrix-org/synapse/issues/1444 I have found some notes bout that the user search only returns profiles of users in public rooms. But this is all a guess and I need to look into it further.

weeman1337 avatar Sep 29 '23 12:09 weeman1337

Element Web seems to send the correct requests and also handles responses correctly. If test failures are too painful in CI we can deactivate the test until the issue is solved.

weeman1337 avatar Sep 29 '23 12:09 weeman1337

... it's certainly true that the public user directory is populated asynchronously within synapse. If the cypress tests aren't taking account of that, it could well explain the problem

richvdh avatar Sep 29 '23 13:09 richvdh

cypress is dead, long live playwright

richvdh avatar Feb 29 '24 15:02 richvdh

... except this is still disabled

richvdh avatar Feb 29 '24 15:02 richvdh

This flaky test issue has not been updated in 14 days. It is being closed as presumed resolved.

github-actions[bot] avatar Apr 24 '24 01:04 github-actions[bot]

This flaky test issue has not been updated in 14 days. It is being closed as presumed resolved.

github-actions[bot] avatar May 17 '24 01:05 github-actions[bot]

Closing as fixed

t3chguy avatar Oct 31 '24 12:10 t3chguy