element-web icon indicating copy to clipboard operation
element-web copied to clipboard

Remove message audio element (for another pr)

Open SuperKenVery opened this issue 2 years ago • 2 comments

Checklist

  • [x] Tests written for new code (and old code if feasible)
  • [x] Linter and other CI checks pass
  • [x] Sign-off given on the changes (see CONTRIBUTING.md)

Works with https://github.com/matrix-org/matrix-react-sdk/pull/10995

Signed-off-by: 许煜恒 [email protected]

Type: defect


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Remove message audio element (for another pr) (#25477). Contributed by @SuperKenVery.

SuperKenVery avatar May 30 '23 10:05 SuperKenVery

Cannot pass test because

https://github.com/matrix-org/matrix-react-sdk/pull/10995#issuecomment-1569320311

SuperKenVery avatar May 31 '23 00:05 SuperKenVery

Hmm... seems true. Currently it works because sound other than message ringtone hasn't been played...

Will try to do that more thoroughly :D

SuperKenVery avatar Jun 26 '23 14:06 SuperKenVery