element-web icon indicating copy to clipboard operation
element-web copied to clipboard

Clicking a Matrix ID in the timeline takes the user to the home screen

Open anoadragon453 opened this issue 1 year ago • 1 comments

Steps to reproduce

  1. Click a Matrix ID in the timeline

Outcome

What did you expect?

The user profile sidebar to appear.

What happened instead?

The user profile sidebar appeared, but with a broken back button, and unexpectedly being redirected to the Home screen.

Screencast from 09-22-2022 05:44:49 PM.webm

In the video I click the back button twice, causing it to disappear (clicking it once does nothing).

Operating system

Arch Linux

Application version

Element version: 2022090801 Olm version: 3.2.12

How did you install the app?

The AUR

Homeserver

No response

Will you send logs?

Yes

anoadragon453 avatar Sep 22 '22 16:09 anoadragon453

It seems to work as expected if the MXID is a pill, but not if it is plain text

uhoreg avatar Sep 23 '22 17:09 uhoreg

This sorta makes sense to me since pill is always a member of the room but a matrix.to link does not have to be

SimonBrandner avatar Sep 24 '22 05:09 SimonBrandner

@SimonBrandner well, usually. Though you can copy/paste pills between rooms or craft them via devtools. In that case clicking the pill, even if the user is not in the room, results in no redirects occurring.

anoadragon453 avatar Sep 26 '22 13:09 anoadragon453

This issue also occurs when the MXID belongs to a user in the room.

uhoreg avatar Oct 04 '22 16:10 uhoreg

This now takes me to matrix.to in the same tab :/

t3chguy avatar Jul 13 '23 12:07 t3chguy

This works fine on riots.im/1.11.35 but not on develop. This seems to be related to @Johennes updating linkifyjs :/

t3chguy avatar Jul 14 '23 09:07 t3chguy

Looks like it is due to 4.1.1

Ensure function options get called with unformatted href

t3chguy avatar Jul 14 '23 09:07 t3chguy

Thanks for fixing this @t3chguy!

Johennes avatar Jul 14 '23 15:07 Johennes