element-web icon indicating copy to clipboard operation
element-web copied to clipboard

Date separator lines are barely visible in light mode

Open robintown opened this issue 3 years ago • 5 comments

Steps to reproduce

  1. Use light mode
  2. Look at a date separator in the timeline

Outcome

What did you expect?

The date separator line should have a decent level of contrast

What happened instead?

They're barely visible:

Screenshot 2022-05-09 at 11-50-00 Element 1 Test room

For comparison, they have significantly more contrast in dark theme:

Screenshot 2022-05-09 at 11-50-59 Element 1 Test room

Operating system

NixOS unstable

Browser information

Firefox 99.0.1

URL for webapp

develop.element.io

Application version

Element version: 1783645108b8-react-e05a3e644659-js-706b4d605481 Olm version: 3.2.8

Homeserver

Synapse 1.58.0

Will you send logs?

No

robintown avatar May 09 '22 15:05 robintown

@nadonomy, do you think they should stand out more?

SimonBrandner avatar May 09 '22 16:05 SimonBrandner

Yeah, perhaps @gaelledel you could suggest a better colour variable for us to use from Compound which will look good on both light & dark?

nadonomy avatar May 11 '22 11:05 nadonomy

Removing 'Needs-Design' as will be resolved through EX work.

rufuskahler avatar Jan 24 '23 16:01 rufuskahler

@rufuskahler removing X-Needs-Design means anyone can just start it with assets already provided in the issue, (e.g. community) - that does not appear to be the case - as without knowing how design expects this to look this will be impossible to contribute.

t3chguy avatar Jan 30 '23 12:01 t3chguy

Removing the a11y label, as it is not a requirement for those decorative lines to pass any contrast check. This however could be a stylistic choice

germain-gg avatar Jul 19 '23 08:07 germain-gg