element-web
element-web copied to clipboard
element-hq
per-room RightPanel should not remember Notifications card, as it's global
Steps to reproduce
- Be in a room
- Display the notifications panel to check for missed notifs in general
- Move to a different room
- Go back again
- Feel confused by the rightpanel showing notifications, given notifications are global, not per-room.
Outcome
What did you expect?
Don't restore the notificationpanel when you view a room (similar to https://github.com/vector-im/element-web/issues/21487, but for unexpectedly getting dumped in the notifpanel)
Operating system
No response
Application version
No response
How did you install the app?
No response
Homeserver
No response
Will you send logs?
No
Related: https://github.com/vector-im/element-web/issues/5383
For contributors: scoping this issue to exactly what's described in the title is best, as otherwise the scope gets complex. Talk to us in #element-dev:matrix.org for questions :)
@SimonBrandner @turt2live Please can you elaborate me how to reproduce this bug.
Don't restore the notificationpanel when you view
In room A open the notif panel, switch to room B, switch back to room A, see the notif panel open again (which it shouldn't be)
@SimonBrandner interesting, i should probably give it a try, you can assign me the issue if @arpit-maurya doesn't work on it or you can assign us both if it's possible
Hi, I am Shivrani, I am selected as outreachy initial applicant, Please can you assign this issue to me?
Hi, I am Shivrani, I am selected as outreachy initial applicant, Please can you assign this issue to me?
I've assigned you to the issue. If you need any help/have any questions be sure to visit #element-dev:matrix.org!
Hi, I am Shivrani; I am selected as outreachy initial applicant, Please can you assign this issue to me?
I've assigned you to the issue. If you need any help/have any questions be sure to visit #element-dev:matrix.org!
Yaa, sure I will communicate there for doubts.
https://github.com/matrix-org/matrix-react-sdk/pull/8273 may be still under development. I have asked there.
