element-web icon indicating copy to clipboard operation
element-web copied to clipboard

Missing comma and I would also take the ellipsis away

Open chagai95 opened this issue 4 years ago • 7 comments

took me a while to find the mistake and "comment" and I think it'll take other even longer...

Signed-off-by: Chagai Friedlander [email protected]

chagai95 avatar May 10 '21 16:05 chagai95

Your example is still invalid, just in a different way.

username-colors is expected to contain 8 colors. avatar-background-colors is expected to contain 3 colors.

It is why it was the way it was with the ...

t3chguy avatar May 10 '21 18:05 t3chguy

Should I open an issue for this then? The code is invalid but it still works, what's are username colors? I'm assuming avatar background colors are the generated profile pictures?

chagai95 avatar May 11 '21 07:05 chagai95

I think the missing comma is definitely a mistake though is it not?

chagai95 avatar May 11 '21 07:05 chagai95

what's are username colors?

image

t3chguy avatar May 11 '21 08:05 t3chguy

Ah 🤦 thx 😊

chagai95 avatar May 11 '21 08:05 chagai95

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 06 '24 17:09 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: turt2live
:x: chagai95
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 06 '24 17:09 CLAassistant

Skipping the CLA requirement since this was written way before the requirement was introduced

richvdh avatar Oct 24 '24 09:10 richvdh