element-web icon indicating copy to clipboard operation
element-web copied to clipboard

Wire up electron download progress to toasts

Open t3chguy opened this issue 4 years ago • 4 comments

Requires https://github.com/matrix-org/matrix-react-sdk/pull/5863 Requires https://github.com/vector-im/element-desktop/pull/184

Fixes https://github.com/vector-im/element-desktop/issues/713 Fixes https://github.com/vector-im/element-desktop/issues/699

Blocked on https://github.com/vector-im/element-desktop/issues/727 - due to this issue only e2ee downloads work in EleDesktop - and those are "instantaneous" as they're just from in-memory blobs so this is somewhat untested and blocked as such.

Probably could do with a progress bar and other fanciness, potentially also merging all active downloads into a single toast maybe or something like that.


Here's what your changelog entry will look like:

✨ Features

  • Wire up electron download progress to toasts (#16947). Fixes vector-im/element-desktop#713 and vector-im/element-desktop#699.

t3chguy avatar Apr 14 '21 10:04 t3chguy

and those are "instantaneous" as they're just from in-memory blobs

Hey @t3chguy , does this mean there will be no download progress bar for encrypted media?

chagai95 avatar Aug 02 '21 07:08 chagai95

With this work as it stands, it'd be near instant. More work needs to be done to hook it onto the download and decrypt process. Hence it being a draft.

t3chguy avatar Aug 02 '21 07:08 t3chguy

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 06 '24 17:09 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 06 '24 17:09 CLAassistant

This PR has been automatically closed because it has been stale for 180 days. If you wish to continue working on this PR, please ping a maintainer to reopen it.

github-actions[bot] avatar Apr 16 '25 02:04 github-actions[bot]