element-hq
It's confusing that Replies to your own messages (and highlights in general?) are entirely coloured red.
It's probably fine that replies to your own messages get turned into highlights. But it's not ideal that it makes the whole message red. And in fact, highlights in general probably shouldn't be entirely red - only the bit which actually highlighted you.
Related:
- https://github.com/vector-im/riot-web/issues/7334
- https://github.com/vector-im/riot-web/issues/6747
- https://github.com/vector-im/riot-web/issues/8821
- An issue for only highlighting your name, not the whole message. Can't find it though.
From discussion on https://github.com/matrix-org/matrix-react-sdk/pull/2896
it sounds like we need to find a different approach that still highlights even without pills.
I'm on the web client and I see mentions are highlighted with a light yellow background color. Wouldn't that be sufficient, or am I misunderstanding the discussion?
A bit of a tangent, but I'd also like to suggest changing the color from red to anything else. Red in UI is associated with error/danger states, so as an end user I wasn't sure if it indicated some problem the first time I saw it.
Here's a screenshot of how replies look currently:
It's worth noting that it doesn't appear this way on mobile:
Both screenshots taken from the perspective of the user "Jimmy". (Shared with Sama's permission)
As others have noted, the red is quite ugly and bad. I hope that the Element team will improve things, or at least give us an option to disable message highlights.
My personal opinion is that the yellowed background is enough to highlight a message, and the text doesn't need to change color as well. This is how Discord does mentions:
Related https://github.com/vector-im/element-web/issues/13963 https://github.com/vector-im/element-web/issues/13964
This issue is now nearly 2 years old, any progress made? It really annoys me.
@CubicrootXYZ The earlier fix at matrix-react-sdk/pull/2896 was closed because at that time there was not always another indication that the message was highlighted. Since then the relevant css has been changed to include the yellow background and the red text (source here). This stylesheet sets the text color to $event-highlight-fg-color which is in turn set to $warning-color.
As far as I can tell, there are no blockers to this issue at the moment. If so, I can make a PR for the issue and hope it lands in the release channel eventually.
For the record, https://github.com/matrix-org/matrix-react-sdk/pull/3553 has fixed the main point of this issue, which was that replies that pinged you would highlight the entire replied-to message. I assume there's still scope though for something like https://github.com/matrix-org/matrix-react-sdk/pull/5724 to improve the situation further.
My personal opinion is that the yellowed background is enough to highlight a message, and the text doesn't need to change color as well. This is how Discord does mentions:
Just came here to say exactly this - Discord example is great way to highlight a message containing mention without giving feels of danger to the user.
For a while I thought it was just "unverified recipient" but it wasn't.
I don't think replies should color the entire message red, especially not in one-on-one chats.
@nhhollander I just want to thank you for tackling this with your PR. Thank you!! I hope to see this change in a future update soon.
@mdsina I've been tied up with work lately, but I might have some time tonight or later this week to revisit this.
This is especially annoying when your name is also an english word. I get red messages anytime someone uses the work mark. Is it possible to remove this and only notify when someone does @name?
@blark
Only one I've hear is that you totally disable notifications/pings except for custom keyword that is your full @user:homeserver.com
I'm honestly really surprised that the ping method is currently and has remained this rigid and annoying.
matrix-org/matrix-react-sdk#3553
Can we please get rid of this annoying red warning color in replies? This thread has been open for 4 years now and still nothing has been done. It's such an easy fix and I am convinced some people aren't using Element simply because of this warning color being used. For the sake of increased adoption and ease on all of our eyes, please change the text color to literally anything else legible.
Spamming issues and PRs with similar comments isn't going to make people inclined to fix it, honestly. The team is currently focusing on other areas of the app, but that doesn't mean a PR is forbidden on this: please absolutely open one if you're confident in the change.
@turt2live There is a PR open about this but it's just sitting still.
Seriously anything besides the current alert fatigue inducing red would be an improvement over the years long standstill going on.
I don't know if it's the perfect that has become the enemy of good or it has simply fallen through the cracks, but it's seriously silly and can trivially be remediated to a large extent.
I agree. Almost no one uses the reply function for serious discussions with long replies in the matrix debate rooms I participate, because the long red texts are unpleasant to the eyes.
Wouldn't it be a 2 minutes fix for a developer (just change the RBG value to make the texts white)? It should be an easy fix for wider adoption.
Wouldn't it be a 2 minute fix for a developer?
Yup, it will be. Once the Design team issues instruction to do so
We do already have design instruction, actually, but https://github.com/matrix-org/matrix-react-sdk/pull/9199 cannot currently be merged, because there is still outstanding work to be done: specifically, highlighting any custom keywords that caused the notification by placing them in red pills, just like @room and @user pills look today, except without the avatar. This is non-trivial, so we are very much open to community contributions that would help implement this final piece.
Just chiming in with support for toning this style down. I spent an hour just now updating element on all of my devices and checking logs on my server, wondering why some of my messages were indicating an error despite apparently being received on all of my other devices, others being able to reply and react to them, etc.
Turns out this is just how a normal reply looks? That was confusing... Red usually indicates a problem!
haiii I noticed the red text and honestly was really confused. Probably because red is used for warnings and "Dangerous Buttons" everywhere else in the app. I would prefer the color being customizable, like a setting where it can be changed to pink or blue or whatever (ideally you could have a color picker or the option to input an HTML color code. I dont mind that red+yellow may look ugly, i just think i broke something when i see red text
https://github.com/element-hq/element-meta/issues/744#issuecomment-1440712735
We do already have design instruction, actually, but matrix-org/matrix-react-sdk#9199 cannot currently be merged, because there is still outstanding work to be done: specifically, highlighting any custom keywords that caused the notification by placing them in red pills, just like @room and @user pills look today, except without the avatar. This is non-trivial, so we are very much open to community contributions that would help implement this final piece.
I've opened a PR that resolves this issue and implements Robin's suggestion for notification keywords above!
- ~~https://github.com/element-hq/matrix-react-sdk/pull/85~~
- https://github.com/element-hq/element-web/pull/28270 Updated PR for element-web, as matrix-react-sdk was incorporated and archived on 2024-10-22
| Before | After |
|---|---|
A few words:
This issue was consistently brought up by every user that I've onboarded on to Element/Matrix. I've been waiting for about 5 years for this to be addressed.
There have been at least five different tickets opened and four attempted pull requests targeting this issue.
It breaks my heart to see such a trivial and immediate source of friction kept alive for 5 years by bikeshedding — I want to be excited about Element, I want to be able to recommend Matrix to people, for there to be a mature, user-friendly client that they can comfortably jump into, but things like this make my confidence in the project waver.
A step in the right direction is so much better than no step at all — I would exchange a glaring UX issue like this for a minor edge-case in clarity any day.
Not every issue needs to be taken out in a single swing. It's okay to roll out what you have right now, to alleviate an issue that impacts the impression of virtually all new users (where stopping the bleeding as early as possible is the priority!) — and then follow-up later on the more minor edge-cases that deserve consideration (especially when you already know what the regressions will be and can proactively prepare tickets and design for them!).
This is a significantly preferable alternative to letting the situation remain unimproved for half a decade.
I always though the red was something to do with encryption failing or something. Bad UX! Hope this can be improved. I like @taffyko's work on the matter and it seems more intuitive. Great job!
I'm honestly surprised it was left like this for that long. It seems like an easy patch and it threw me off for a while thinking it was insecure to send replies 💀
