[Story] EX: Make the room "Security & privacy" screen available

[manuroe]

Description

• As a user and admin of a room
• I want to access to the room "Security & Privacy" screen even if dev settings for "Ask to join" is disabled
• So that I can set the desired settings

Currently, the "Ask to join" feature flag prevent from entering this screen. Instead this flag should only hide the red part below:

Acceptance criteria

• "Security & Privacy" screen is available for users who has enough power, even if "Ask to join" flag is disabled
• When the "Ask to join" flag is enabled, The "Ask to join" option is available in the menu
• If not, the option is hidden
• There is an exception. If the room is already Ask to join, the option is displayed. It appears disabled if the flag is off.

Time sheeting

Let's do it as part of the spaces work (we need the same screen for spaces) ER-145: EX Spaces to Sunset Legacy

Documentation

Dependencies

• None

Out of scope

• Nothing

Open questions

• ?

Sign-offs

• [ ] Android
• [ ] iOS

[bmarty]

We wanted to improve the UX about the "enable encryption" switch too, maybe a good opportunity to do it before making this screen more visible? I do not remember where this was discussed, but the issue is that when the user enables encryption, there is a warning dialog saying that this cannot be undone, then even if the user confirms, the encryption is not enabled until the user clicks on "Save".

[bmarty]

@manuroe I am handling this change on Android and there is a case where the FF is not enabled and the current room access setting of the room is Ask to join. I guess in this case we cannot just hide the option.

I propose to just disable the option if the FF is not enabled, but always show it. Do you agree?

[manuroe]

yes, it makes sense. If the room is already Ask to join, display the setting whatever the FF value is.

[bmarty]

If the room is already Ask to join, display the setting whatever the FF value is.

Thanks. This is not exactly what I was proposing but it makes sense too. Will do that!

[bmarty]

Sorry I have not seen that before, but there is already a disabled case for the Restricted state (Space members), and the option is shown only if the current value is Restricted. When shown, the option is disabled. Maybe we should align and do the same for Knock?

[bmarty]

Here is the result when the option is "Ask to join" and the feature flag is disabled:

[manuroe]

Thanks @bmarty. Let's do as per your screenshot. The UX is a bit weird like it is hard to understand why it is greyed out but this case should not happen that often. We will have knocking at some point in EW and we will be able to enable the flag.

I updated the acceptance criteria accordingly.