element-ios icon indicating copy to clipboard operation
element-ios copied to clipboard

Check power level before starting live sharing location

Open NicolasBuquet opened this issue 1 year ago • 2 comments

Pull Request Checklist

  • [x] I read the contributing guide
  • [ ] UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • [ ] Accessibility has been taken into account.
  • [x] Pull request is based on the develop branch
  • [x] Pull request contains a changelog file in ./changelog.d
  • [x] You've made a self review of your PR
  • [ ] Pull request includes screenshots or videos of UI changes
  • [x] Pull request includes a sign off

NicolasBuquet avatar Jun 13 '24 09:06 NicolasBuquet

@pixlwave A small change to enhance Element iOS ;-)

We made this change on Tchap.

NicolasBuquet avatar Jun 13 '24 09:06 NicolasBuquet

@giomfo Can you follow these please. Thanks 🙏

NicolasBuquet avatar Jun 24 '24 10:06 NicolasBuquet

@NicolasBuquet Are you planning on coming back to this PR? We still need a rebase for CI to pass please.

pixlwave avatar Jul 17 '24 12:07 pixlwave

@NicolasBuquet Are you planning on coming back to this PR? We still need a rebase for CI to pass please.

Hello @pixlwave I finished on this PR. It's ok for me. The CI is quite broken for me and I don't intend to fix it. Thank you for your involvement.

NicolasBuquet avatar Aug 14 '24 09:08 NicolasBuquet

@NicolasBuquet If you rebase your branch (or merge develop into your branch if that's easier) that's all we need, CI will work and I can merge this PR for you :)

pixlwave avatar Aug 14 '24 09:08 pixlwave

@NicolasBuquet If you rebase your branch (or merge develop into your branch if that's easier) that's all we need, CI will work and I can merge this PR for you :)

Merge done @pixlwave

NicolasBuquet avatar Aug 14 '24 14:08 NicolasBuquet

Replacing this PR with https://github.com/element-hq/element-ios/pull/7832 as #7778 seems to have slipped into here too.

pixlwave avatar Aug 14 '24 15:08 pixlwave