element-ios icon indicating copy to clipboard operation
element-ios copied to clipboard

Check filesize before uploading file to server and display alert if file is too big

Open NicolasBuquet opened this issue 1 year ago • 2 comments

Check filesize before uploading file to server and display alert if file is too big

This test is present in the Android version of Element, but curiously not in the iOS version.

Pull Request Checklist

  • [x] I read the contributing guide
  • [ ] UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • [ ] Accessibility has been taken into account.
  • [x] Pull request is based on the develop branch
  • [x] Pull request contains a changelog file in ./changelog.d
  • [x] You've made a self review of your PR
  • [x] Pull request includes screenshots or videos of UI changes
  • [x] Pull request includes a sign off

image

NicolasBuquet avatar Apr 17 '24 17:04 NicolasBuquet

@pixlwave Can you have a look at this PR ?

NicolasBuquet avatar Apr 17 '24 17:04 NicolasBuquet

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 12.32%. Comparing base (a5d4d1c) to head (f16203a). Report is 41 commits behind head on develop.

:exclamation: Current head f16203a differs from pull request most recent head 90f1122

Please upload reports for the commit 90f1122 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7778      +/-   ##
===========================================
+ Coverage    12.27%   12.32%   +0.05%     
===========================================
  Files         1651     1651              
  Lines       164167   163958     -209     
  Branches     67499    67364     -135     
===========================================
+ Hits         20148    20209      +61     
+ Misses      143346   143112     -234     
+ Partials       673      637      -36     
Flag Coverage Δ
uitests 55.67% <ø> (+0.65%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 15 '24 15:05 codecov[bot]

@NicolasBuquet Also, are you planning on coming back to this PR too?

pixlwave avatar Jul 17 '24 12:07 pixlwave

@NicolasBuquet Also, are you planning on coming back to this PR too?

Hello @pixlwave No, I don't push anymore to this PR.

Too complicated. IMO, it needs changes in matrix-ios-sdk to be properly implemented. Thank you for your involvement.

NicolasBuquet avatar Aug 14 '24 09:08 NicolasBuquet

Ok, thank you for your time looking into this anyway :)

pixlwave avatar Aug 14 '24 09:08 pixlwave