element-ios icon indicating copy to clipboard operation
element-ios copied to clipboard

ThemeService: add a 'Auto (Black)' theme option

Open tamcore opened this issue 3 years ago • 5 comments

Closes #5966 and #6959.

Pull Request Checklist

  • [X] I read the contributing guide
  • [X] UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • [x] Accessibility has been taken into account.
  • [X] Pull request is based on the develop branch
  • [X] Pull request contains a changelog file in ./changelog.d
  • [X] You've made a self review of your PR
  • [X] Pull request includes screenshots or videos of UI changes
    • https://user-images.githubusercontent.com/319917/200836824-2a7000e3-3179-4c0f-995d-5f16ad9100df.mp4
  • [X] Pull request includes a sign off

tamcore avatar Nov 09 '22 13:11 tamcore

Can you request a review?

BerndSchmecka avatar Nov 19 '22 11:11 BerndSchmecka

@BerndSchmecka unfortunately don't have any buttons or whatsoever for that. Also asked in the Matrix channel but didn't get any feedback :(

tamcore avatar Nov 19 '22 11:11 tamcore

Oh :( Hopefully someone with write access will find this PR and review it so that everyone can enjoy the black theme only at night ^^

BerndSchmecka avatar Nov 19 '22 13:11 BerndSchmecka

Approved from Product perspective.

daniellekirkwood avatar Nov 21 '22 16:11 daniellekirkwood

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 25 '24 11:09 CLAassistant