Oct 14 '22 18:10 yostyle

Codecov Report

Base: 6.17% // Head: 6.14% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (1d8c903) compared to base (5f6baa7). Patch coverage: 0.00% of modified lines in pull request are covered.

:exclamation: Current head 1d8c903 differs from pull request most recent head 369a4f9. Consider uploading reports for the commit 369a4f9 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6891      +/-   ##
===========================================
- Coverage     6.17%    6.14%   -0.03%     
===========================================
  Files         1571     1593      +22     
  Lines       156063   156653     +590     
  Branches     63027    63217     +190     
===========================================
  Hits          9632     9632              
- Misses      146002   146592     +590     
  Partials       429      429

Impacted Files	Coverage Δ
Config/BuildSettings.swift	`43.07% <ø> (ø)`
Riot/Modules/Room/CellData/RoomBubbleCellData.m	`0.00% <0.00%> (ø)`
Riot/Modules/Room/RoomCoordinator.swift	`0.00% <0.00%> (ø)`
Riot/Modules/Room/RoomViewController.m	`0.00% <0.00%> (ø)`
...lls/Styles/Bubble/BubbleRoomTimelineCellProvider.m	`0.00% <0.00%> (ø)`
...st/Incoming/VoiceBroadcastIncomingBubbleCell.swift	`0.00% <0.00%> (ø)`
...oadcastIncomingWithPaginationTitleBubbleCell.swift	`0.00% <0.00%> (ø)`
...BroadcastIncomingWithoutSenderInfoBubbleCell.swift	`0.00% <0.00%> (ø)`
...oadcastOutgoingWithPaginationTitleBubbleCell.swift	`0.00% <0.00%> (ø)`
...BroadcastOutgoingWithoutSenderInfoBubbleCell.swift	`0.00% <0.00%> (ø)`
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Oct 14 '22 18:10 codecov[bot]

:iphone: Scan the QR code below to install the build for this PR. :lock: This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/W3CRHP

Oct 15 '22 21:10 github-actions[bot]

@yostyle

It could be nice to have more context in the description of this PR :)

Oct 17 '22 11:10 gileluard

@yostyle

It could be nice to have more context in the description of this PR :)

Hi @gileluard, the voice broadcast implementation is detailed here. In this PR, @yostyle is aggregating the multiple voice messages sent during a unique voice broadcast.

Oct 17 '22 11:10 giomfo

@yostyle I would like to hide from the room timeline the voice messages sent for a voice broadcast (whatever if the feature is enabled or not)

What do you think about tag the RoomBubbleCellData instances created for these voice messages with RoomBubbleCellDataTagVoiceBroadcast tag here? They will not have display anymore

Oct 17 '22 12:10 giomfo

Kudos, SonarCloud Quality Gate passed!