element-ios icon indicating copy to clipboard operation
element-ios copied to clipboard

Sharing menu allows selecting multiple rooms despite using radio buttons

Open haecker-felix opened this issue 1 year ago • 1 comments

Steps to reproduce

  1. Share content from iOS share menu, click "Element"
  2. Seeing a long list of rooms, click by mistake on a random wrong room [Whose content you do NOT want to share]
  3. Instead scrolling through the long list, enter the room name in the search entry
  4. Activate the radio button of the right room whose content you want to share

Outcome

What did you expect?

Since the list is using radio buttons, I expect that only one item can be selected, namely the room from "4."

What happened instead?

These are NOT radio buttons, although they look like it, and there were 2 rooms selected (room from "4." and "2."), so I shared private content to a room with a lot of people.

image

This can have fatal consequences, because you don't realize this when you make this mistake. I noticed it by coincidence, because someone asked me about it.

Since it is possible to select multiple rooms, checkboxes should be used instead of radio buttons (makes it obvious that several rooms can be selected). In addition, an indicator should be displayed somewhere to show how many rooms are selected, since it is possible that a selected room is no longer visible if it has been filtered out by the search entry.

Your phone model

iPhone Xs

Operating system version

iOS 16

Application version

Element 1.9.4

Homeserver

No response

Will you send logs?

No

haecker-felix avatar Sep 11 '22 09:09 haecker-felix

Good point, thanks for opening the issue. I've tagged it for the design team to take a look at 👍

pixlwave avatar Sep 13 '22 08:09 pixlwave