element-ios
element-ios copied to clipboard
Fix blank room screen
I couldn't reproduce the issue by playing with network connection. I could see a blank screen but also a syncing spinner was there.
The issue seen on iPad was due to an unnecessary inputAccessoryView
on message text view. Somehow the table view was insetted wrongly (so that all the content to be out of screen).
This PR also addresses some suspicious UITableView
errors i saw in logs.
There may be other cases for the issue we're not aware of yet.
-
Element[4045:46257] [Assert] Attempted to access the table view's visibleCells while they were in the process of being updated, which is not allowed. Make a symbolic breakpoint at UITableViewAlertForVisibleCellsAccessDuringUpdate to catch this in the debugger and see what caused this to occur. Perhaps you are trying to ask the table view for the visible cells from inside a table view callback about a specific row? Table view: <UITableView: 0x7fc1d0150000; frame = (0 0; 428 777); autoresize = RM+BM; gestureRecognizers = <NSArray: 0x6000010835a0>; layer = <CALayer: 0x600001d853c0>; contentOffset: {0, 0}; contentSize: {428, 1998.6666641235352}; adjustedContentInset: {0, 0, 34, 0}; dataSource: <RoomDataSource: 0x7fc1c72d13e0>>
-
Element[4288:55918] [TableView] Warning once only: UITableView was told to layout its visible cells and other contents without being in the view hierarchy (the table view or one of its superviews has not been added to a window). This may cause bugs by forcing views inside the table view to load and perform layout without accurate information (e.g. table view bounds, trait collection, layout margins, safe area insets, etc), and will also cause unnecessary performance overhead due to extra layout passes. Make a symbolic breakpoint at UITableViewAlertForLayoutOutsideViewHierarchy to catch this in the debugger and see what caused this to occur, so you can avoid this action altogether if possible, or defer it until the table view has been added to a window. Table view: <UITableView: 0x7fc927027a00; frame = (0 0; 428 868); hidden = YES; autoresize = RM+BM; gestureRecognizers = <NSArray: 0x6000018f4360>; layer = <CALayer: 0x6000016d5060>; contentOffset: {0, 0}; contentSize: {428, 0}; adjustedContentInset: {0, 0, 0, 0}; dataSource: (null)>
-
iPad issue after orientation changes (reported at https://matrix.to/#/!NMoyFpQxIVYaQIfQHG:matrix.org/$Pf9_zjq5XrNPmWCI57DjdYnFcffH3NcS0iNHJKvx6rY?via=matrix.org&via=element.io&via=one.ems.host)
Fixes #5932
:iphone: Scan the QR code below to install the build for this PR. :lock: This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ceBgea
Codecov Report
Merging #6565 (98338fd) into develop (6f0d796) will increase coverage by
0.01%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## develop #6565 +/- ##
===========================================
+ Coverage 6.28% 6.29% +0.01%
===========================================
Files 1458 1458
Lines 153924 153931 +7
Branches 61867 61875 +8
===========================================
+ Hits 9668 9692 +24
+ Misses 143850 143831 -19
- Partials 406 408 +2
Impacted Files | Coverage Δ | |
---|---|---|
Riot/Modules/Room/MXKRoomViewController.m | 0.00% <0.00%> (ø) |
|
Riot/Modules/Room/RoomViewController.m | 0.00% <0.00%> (ø) |
|
...les/Room/Views/InputToolbar/RoomInputToolbarView.m | 0.00% <ø> (ø) |
|
...ing/SplashScreen/View/OnboardingSplashScreen.swift | 58.66% <0.00%> (+4.00%) |
:arrow_up: |
...Modules/Common/ViewModel/StateStoreViewModel.swift | 50.00% <0.00%> (+19.44%) |
:arrow_up: |
...SplashScreen/OnboardingSplashScreenViewModel.swift | 53.84% <0.00%> (+42.30%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.