element-ios icon indicating copy to clipboard operation
element-ios copied to clipboard

Rework `RecentsViewControllerDataReadyNotification` to something more solid

Open aringenbach opened this issue 3 years ago • 0 comments

Your use case

The RecentsViewControllerDataReadyNotification is used to trigger the end of the initial sync spinner, as it is trusted to notify when the data is actually ready.

Currently having the RecentsViewControllerDataReadyNotification actually sent is tied to having sections inside the presented tableView within the RecentsViewController.

While this is always the case in Element-iOS, some fork could, for example, deactivate the Home screen and therefore have the Favorites as the first screen shown in the application. This particular setup would result in any user that actually don't have any favorites to have an infinite initial sync spinner.

See RecentsViewController's - (void)dataSource:(MXKDataSource *)dataSource didCellChange:(id)changes and RecentsDataSource's - (void)recentsListServiceDidChangeData:(id<RecentsListServiceProtocol>)service forSection:(RecentsListServiceSection)section totalCountsChanged:(BOOL)totalCountsChanged

Have you considered any alternatives?

No

Additional context

None

aringenbach avatar Jul 07 '22 13:07 aringenbach