element-hq
the app doesn't allow to add a DM to a space, only rooms
if i go to the add existing room section and filter on the name of one of my DM, it says there is no result
@gileluard Is this expected behaviour for the implementation? I checked on web and I can add a DM to a space.
It's expected behaviour but I may have misunderstood the requirements. Please assign it to me and I'll fix it.
@niquewoodhouse
Basically the Add rooms screen displays an unsorted list of non DM rooms. I can easily include DM rooms but the screen is still messy:
I can sort rooms by name and group them by type: Favourites, People, Rooms this way:
I can sort rooms by name and group them by type: Favourites, People, Rooms this way:
Putting things in sections sounds good but I'm not completely sure if we should allow you to add DM to a space this way, for all spaces.
if i go to the add existing room section and filter on the name of one of my DM, it says there is no result
At the moment you can only add existing rooms, or invite people to join a space. If you have a DM with that person, when they join, that DM will be visible in that space. If your space is private and just for you, you can add DMs through the add existing rooms button on web, but this is the only kind of space where you can do that. If this issue is just copying that behaviour from web, sounds good to me.
But if its adding this to every type of space, I think It could be confusing - am I adding that person to the space? @nadonomy would be keen to hear your thoughts from a product pov.
@nadonomy @niquewoodhouse & @gileluard From scroll back it looks like the suggestion is to make DMs available in this list when the space is private, but not when it's public. Makes sense to me...
If you disagree with this approach, please comment. If there are no comments by the time we take on this issue, thats the behaviour we'll move forwards with...
Alternatively; we copy web behaviour and allow DM selection for all space types. I do not think we can exclude DMs completely.
Element 1.9.9 20221018161714 Can't add existing room to space, there is not ADD BUTTON. When I switch between New/Existing the ADD BUTTON just disappeared, I have selected the rooms ready to be Added.
