element-desktop icon indicating copy to clipboard operation
element-desktop copied to clipboard

"New login" popup validation button not doing anything

Open Porkepix opened this issue 8 months ago • 7 comments

Steps to reproduce

  1. Connect a new client
  2. Element desktop pops the pop-up you'll see in the below screenshot asking if it was me
  3. I try to click "Yes, it was me", but it does absolutely nothing and the popup stays here.

Outcome

What did you expect?

It should validate the device

What happened instead?

It did nothing

Additional information:

  • Maybe the client cross-checking with emojis (initiated by the connection on a new client) bypassed it and considered it as validated, therefore this pop-up fails to do what it's supposed to do as it's already done (don't know)
  • I didn't tried the "No" button as I don't want to invalidate that device, so I can't tell if that one would work or no.

Operating system

Arch Linux

Application version

1.11.50-1

How did you install the app?

Package manager

Homeserver

No response

Will you send logs?

No

Porkepix avatar Nov 29 '23 11:11 Porkepix

Please send logs, otherwise it'll need to be closed as a community maintained platform

t3chguy avatar Nov 29 '23 11:11 t3chguy

System logs shows nothing, I've no idea how the Web console should be triggered, and the command highlighted in the issue template doesn't seems to let the user control what will be sent anyway. But I would have checked that console if I found how to trigger it.

Porkepix avatar Nov 29 '23 11:11 Porkepix

image

The template is your friend

t3chguy avatar Nov 29 '23 11:11 t3chguy

image

The template is your friend

Yes, and I've read it. This command seems to send its logs without offering the user to check them first and be able to anonymise what they deems necessary, which I certainly won't do. I always check my logs before sending them in any issue as it could leak information I don't want to (I pretty often need to add manual anonymization).

Porkepix avatar Nov 29 '23 11:11 Porkepix

There's a download button:

image

but if you don't use the upload mechanism to the https://github.com/matrix-org/rageshake server then it won't get processed using our automations and likely take far longer to get to.

t3chguy avatar Nov 29 '23 11:11 t3chguy

Still waiting, but since I started this a couple of minutes after your message, Element's whole UI froze (I can't even click the cancel button), eats up 250% CPU and constantly write 7 to 10MB/s to disk:

Screenshot from 2023-11-29 12-22-00

EDIT: CPU usage and disk writes just stopped, taking at the very least 10 to 15 minutes. But the UI didn't unfreeze. I'll start looking to the places it could have write a file.

EDIT2: The download window wasn't put to foreground and was hidden under the main Element one, after getting to it and saving the file it unfroze the whole UI. Currently scuring the logs to see if I can find anything useful in it considering, as I was afraid, it leaks a tons of metadata: my own matrix ID, the ones of many of the people I'm talking to, the ID of the channels I'm in and so on.

Porkepix avatar Nov 29 '23 11:11 Porkepix

Tries to click the button many new times to have the exact time to look for in the logs, and it prints nothing more than that:

2023-11-29T11:45:00.654Z D Dismissing unverified sessions: foo
2023-11-29T11:45:00.661Z D Old unverified sessions:
2023-11-29T11:45:00.661Z D New unverified sessions:
2023-11-29T11:45:00.661Z D Currently showing toasts for:
2023-11-29T11:45:00.826Z D Dismissing unverified sessions: foo
2023-11-29T11:45:00.835Z D Old unverified sessions:
2023-11-29T11:45:00.835Z D New unverified sessions:
2023-11-29T11:45:00.835Z D Currently showing toasts for:
2023-11-29T11:45:00.996Z D Dismissing unverified sessions: foo
2023-11-29T11:45:01.005Z D Old unverified sessions:
2023-11-29T11:45:01.005Z D New unverified sessions:
2023-11-29T11:45:01.005Z D Currently showing toasts for:
2023-11-29T11:45:01.170Z D Dismissing unverified sessions: foo
2023-11-29T11:45:01.187Z D Old unverified sessions:
2023-11-29T11:45:01.187Z D New unverified sessions:
2023-11-29T11:45:01.187Z D Currently showing toasts for:
2023-11-29T11:45:01.330Z D Dismissing unverified sessions: foo
2023-11-29T11:45:01.348Z D Old unverified sessions:
2023-11-29T11:45:01.349Z D New unverified sessions:
2023-11-29T11:45:01.349Z D Currently showing toasts for:
2023-11-29T11:45:01.510Z D Dismissing unverified sessions: foo

Also found out two interesting things in these logs, completely unrelated to this issue, but I think worth signaling (dunno if it should have its own issue and what to put inside as it's not related to anything I could see user-facing):

This:

2023-11-27T11:17:17.075Z W Possible EventEmitter memory leak detected. 11 call listeners added. Use emitter.setMaxListeners() to increase limit
MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 call listeners added. Use emitter.setMaxListeners() to increase limit
    at d (vector://vector/webapp/bundles/9b3b2c35b6ee65439fee/bundle.js:2:634720)
    at s.addListener (vector://vector/webapp/bundles/9b3b2c35b6ee65439fee/bundle.js:2:637304)
    at q.componentDidMount (vector://vector/webapp/bundles/9b3b2c35b6ee65439fee/bundle.js:2:2725783)
    at _s (vector://vector/webapp/bundles/9b3b2c35b6ee65439fee/bundle.js:2:4655761)
    at Al (vector://vector/webapp/bundles/9b3b2c35b6ee65439fee/bundle.js:2:4672567)
    at t.unstable_runWithPriority (vector://vector/webapp/bundles/9b3b2c35b6ee65439fee/bundle.js:2:4691831)
    at Ki (vector://vector/webapp/bundles/9b3b2c35b6ee65439fee/bundle.js:2:4614707)
    at Il (vector://vector/webapp/bundles/9b3b2c35b6ee65439fee/bundle.js:2:4669306)
    at vl (vector://vector/webapp/bundles/9b3b2c35b6ee65439fee/bundle.js:2:4665417)
    at vector://vector/webapp/bundles/9b3b2c35b6ee65439fee/bundle.js:2:4614930

this (computer might have been offline at that time, but this seems anyway not gracefully handled):

2023-11-27T12:03:39.105Z E /sync error %s fetch failed: Failed to fetch
ConnectionError: fetch failed: Failed to fetch
    at p.requestOtherUrl (vector://vector/webapp/bundles/9b3b2c35b6ee65439fee/bundle.js:2:3707616)
    at async p.authedRequest (vector://vector/webapp/bundles/9b3b2c35b6ee65439fee/bundle.js:2:3705469)
    at async k.doSync (vector://vector/webapp/bundles/9b3b2c35b6ee65439fee/bundle.js:2:785166)

And this, probably the least interesting though:

2023-11-28T15:40:58.412Z D FetchHttpApi: <-- GET https://matrix.org/_matrix/client/v3/sync?filter=xxx&timeout=xxx&set_presence=xxx&since=xxx [110070ms AbortError: The user aborted a request.]
2023-11-28T15:40:58.412Z E /sync error %s The user aborted a request. (AbortError | 20)

Porkepix avatar Nov 29 '23 11:11 Porkepix