element-call icon indicating copy to clipboard operation
element-call copied to clipboard

Multiple group calls can be created in glare-like scenario

Open dbkr opened this issue 3 years ago • 1 comments

Steps to reproduce

We seem to be able to end up with multiple group calls in the same room. In this case we saw, the room got created with a group call in February, and then on July 20th Matthew iphone joined and 4 hours later, created a second group call, before going silent.

So:

  1. There may be some bug in our create-call-if-none-already logic
  2. We should probably handle mutliple group calls in a room in some way, eg. always join the most recently added.
  3. We probably want to guard against this in general. In EC we could add the call to initial_state when creating the room, but this wouldn't help other applications - I've brought this up on the MSC: https://github.com/matrix-org/matrix-spec-proposals/pull/3401/files#r711950320

Outcome

What did you expect?

What happened instead?

Operating system

No response

Browser information

No response

URL for webapp

No response

Will you send logs?

No

dbkr avatar Aug 10 '22 16:08 dbkr

Further investigation reveals that it was probably a bug between #471 and #479 (ie. now fixed) where we didn't wait for the Room event to arrive after trying to join and before creating a call, so we just need to deal with rooms that have been broken by this bug, ie. probably pick the most recent conf.

dbkr avatar Aug 10 '22 16:08 dbkr

Follow up ticket https://github.com/matrix-org/matrix-js-sdk/issues/2589

fkwp avatar Aug 18 '22 13:08 fkwp