element-call icon indicating copy to clipboard operation
element-call copied to clipboard

Should you have to release the same thing you pressed to stop speaking?

Open dbkr opened this issue 3 years ago • 1 comments

Steps to reproduce

With the PTT hardware button patch, we have 3 different ways to start speaking: click/touch button, spacebar and the hardware button (4 if you have both a touchscreen and pointing device). We currently stop speaking whenever any of them are released, which means, for example, if you hold the mouse down on the PTT button, then press space, you'll stop speaking. If you do the inverse (hold space, click the button) you'll briefly stop speaking then start again as the key repeat sends another space keypress.

Should we change it so that you have to release whatever you pressed / clicked / held originally in order to stop speaking? That is, if you click & hold the button then press space, the spacebar press would be ignored.

Outcome

What did you expect?

What happened instead?

Operating system

No response

Browser information

No response

URL for webapp

No response

Will you send logs?

No

dbkr avatar Jul 08 '22 15:07 dbkr

Should we change it so that you have to release whatever you pressed / clicked / held originally in order to stop speaking?

That sounds fine, I think I would advocate for a slightly different option though: the button stays held as long as any of touch, spacebar, PTT button etc. are held. This feels nice to me because it allows you to 'transfer' grip of the button between different controls, for example if you started by clicking the button with your mouse, but then realized you needed to reach for something and switched to holding spacebar with your opposite hand.

robintown avatar Jul 09 '22 17:07 robintown