element-call icon indicating copy to clipboard operation
element-call copied to clipboard

Support MSC4143 RTC Transport endpoint

Open Half-Shot opened this issue 1 month ago • 4 comments

This implements MSC4143's backend endpoint for transports, and uses https://github.com/matrix-org/matrix-js-sdk/pull/5104 to handle it.

This changes makeTransport to:

  • Try all listed transports, not just the first livekit one.
  • Test all backend transports, then all well-known transports, then all config transports.

Half-Shot avatar Dec 11 '25 13:12 Half-Shot

This needs more coverage. It looks like throwing in a test that uses the new endpoint would get you almost to 100% since it would run thorugh both "throw levels"

toger5 avatar Dec 11 '25 16:12 toger5

This needs more coverage. It looks like throwing in a test that uses the new endpoint would get you almost to 100% since it would run thorugh both "throw levels"

Yup! Working through it

Half-Shot avatar Dec 11 '25 16:12 Half-Shot

In other words: I am not sure if:

Test all backend transports, then all well-known transports, then all config transports.

is actually happening. Are we really continuing to check well-known transports if backend transports fail? edit at least in the ex instanceof FailToGetOpenIdToken case. edit Oh which is an issue with our HS and entirely independent of the sfu/jwt. Liking this more and more while looking into it :)

toger5 avatar Dec 11 '25 16:12 toger5

Oh which is an issue with our HS and entirely independent of the sfu/jwt. Liking this more and more while looking into it :)

That was my intention yes, but seeing as it wasn't clear this needs more comments on the PR.

Half-Shot avatar Dec 11 '25 18:12 Half-Shot