element-hq
Advanced audio options
This is matrix-org/matrix-react-sdk#8759 once again on the Element Call side.
Fixes #265 Related to #927
Unfortunately, I don't fully understand how to make things reactive in React, so this initial version does not restart audio tracks automatically when the user changes the settings.
@SimonBrandner Could you please help me with a few hints about the correct implementation? :)
Hi, @MrAnno, unfortunately, I am no longer an active part of the project and do not have much time on my hands atm. I believe @BillCarsonFr will be able to help though :)
Bill seems to be busy, so I'll be a bit cheeky and ask whether Robin's in town.
@robintown Hıo ka
Thx @MrAnno, just letting you know that this was added to the things to look at. Looping back with product.
I wonder if we should also add an option to choose max bitRate (like a mode for playing music AudioPresets.musicHighQuality
@BillCarsonFr Thanks!
That's a wonderful idea. I tried to keep it minimal because last time it took months to get this through the UX team and I was almost told to compress these three options into a single one.
I would be happy to add any options that result in a better overall sound quality in professional audio environment.
@MrAnno as a work around until we have product/design decision, I created this PR to add a URL param to setup echoCancellation and noise suppression. https://github.com/element-hq/element-call/pull/3590
It is not dynamic, you cannot change it mid-call, and it will be wired to the existing EW setting
https://github.com/element-hq/element-web/pull/31317
@BillCarsonFr Thank you.
I'm not sure if it helps, but the previous Element UX decisions were documented below (starting with this comment): https://github.com/matrix-org/matrix-react-sdk/pull/8759#issuecomment-1247866276
This seemed like a carefully thought-out decision that was considered over several months, maybe you can draw ideas from it for Element Call as well.