element-call icon indicating copy to clipboard operation
element-call copied to clipboard

Participant count is incorrect

Open toger5 opened this issue 2 years ago • 3 comments

The participant counter on the top left corner of element call is incorrect.

  • The counter uses the call.member events to parse the current non expired events
  • The exparation is computer by unsigned.age or the origin_server_ts as a fallback if no unsigned.age is unavailable.

The age is only properly set right after the evnt is fetched from the HS. We suspect, this collides with the idea of the sync cache from the js-sdk.

It should only store events with the localTimestamp and not the unsigned.age.

toger5 avatar Dec 11 '23 15:12 toger5

Alternative

The age propery is not fully implement and caused other issues already. age also makes unsigned mutable. So it is important to know when the event was fetched to interpret the unsigned data correctly. It was discussed if instead of an unsigned.age we introduce a enporint to the hs to get_origin_server_now which can be used to compute the offset of the local timestamp and the origin server one. Then the origin_server_ts can be used as an alternative to age.

toger5 avatar Dec 11 '23 15:12 toger5

maybe https://github.com/matrix-org/matrix-spec-proposals/pull/4018 is a proper fix for this issue

fkwp avatar Jan 19 '24 14:01 fkwp

https://github.com/matrix-org/matrix-video-chat-rageshakes/issues/5933 is a rageshake for this

Half-Shot avatar May 21 '24 13:05 Half-Shot