element-call icon indicating copy to clipboard operation
element-call copied to clipboard

Switch devices if the label doesn't match the default

Open dbkr opened this issue 2 years ago • 1 comments

dbkr avatar Oct 06 '23 14:10 dbkr

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (be4afae) 30.13% compared to head (ff5ecab) 30.13%.

Additional details and impacted files
@@           Coverage Diff            @@
##           livekit    #1707   +/-   ##
========================================
  Coverage    30.13%   30.13%           
========================================
  Files           47       47           
  Lines         1868     1868           
  Branches       326      326           
========================================
  Hits           563      563           
  Misses        1263     1263           
  Partials        42       42           
Flag Coverage Δ
unittests 30.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 06 '23 14:10 codecov-commenter

@dbkr does it still make sense to keep this open? What issue was it solving? Can we merge it (whats the reason for it still being a draft PR?)

toger5 avatar Jul 17 '24 08:07 toger5

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 06 '24 08:09 CLAassistant

@dbkr I hope it is okay to ping you again on this topic. If we cannot remember what the problem that this was solving I am advocating closing this and linking it into a (to create) media device EPIC issue as reference.

toger5 avatar Sep 09 '24 12:09 toger5

I remember this was some kind of awful hack, but empirically it's not needed so let's close it.

dbkr avatar Sep 09 '24 12:09 dbkr