element-android icon indicating copy to clipboard operation
element-android copied to clipboard

[SDK] matrix-android-sdk2 uses an unspecced `original_event` field from the `/relations` response

Open clokep opened this issue 3 years ago • 2 comments

Description

The /relations endpoint does not return an original_event field, yet the matrix-android-sdk2 uses it.

We would like to remove support for this from Synapse in < 6 months. See matrix-org/synapse#12930 for more context.

clokep avatar Oct 03 '22 14:10 clokep

From a quick look of consumers, it seems that this is actually used, but I am not 100% certain:

  • https://github.com/matrix-org/matrix-android-sdk2/search?q=originalEvent
  • https://github.com/vector-im/element-android/search?q=originalEvent

clokep avatar Oct 03 '22 15:10 clokep

Yes, this is used. We can try to un-use it, I will check if it's possible to do that fast.

bmarty avatar Oct 03 '22 15:10 bmarty