element-android icon indicating copy to clipboard operation
element-android copied to clipboard

Scrolling up when at the top of the list make FAB dissapear

Open germain-gg opened this issue 2 years ago • 2 comments

Steps to reproduce

  1. Make sure you're scrolled up to the top of the list
  2. Scroll up using one finger

Outcome

What did you expect?

For the FAB to always be visible

What happened instead?

The FAB dissapear for the duration of the finger interaction with the screen

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No

germain-gg avatar Aug 08 '22 09:08 germain-gg

This is already the case with the current Element app in prod. I've checked this with other apps and it's not standard behaviour across Android.

@daniellekirkwood @amshakal do we want to change this behaviour?

ericdecanini avatar Aug 09 '22 06:08 ericdecanini

We should follow the standrard Android behavior in such scenarios.

amshakal avatar Aug 09 '22 09:08 amshakal

So the standard behaviour in Android is that the FAB is always visible? Regardless whether the user is scrolling or not?

daniellekirkwood avatar Aug 15 '22 09:08 daniellekirkwood

Some very little research I did with a couple of apps from google showed me this behaviour, but I think we need a little more research to say for sure. I could be wrong

ericdecanini avatar Aug 17 '22 08:08 ericdecanini

I've relabled this issue as a question as we need some investigation on the desired behaviour

ericdecanini avatar Aug 17 '22 09:08 ericdecanini

According to material 3, on scrolling FAB should be visible still: https://m3.material.io/components/floating-action-button/guidelines. We should stick to native behavior. We can change it later if needed

amshakal avatar Aug 17 '22 11:08 amshakal

Thanks for looking into this @amshakal! I'll close this issue following that

ericdecanini avatar Aug 18 '22 15:08 ericdecanini